Coder Social home page Coder Social logo

Comments (8)

groob avatar groob commented on August 28, 2024

I'd like some clarification on this as well.

from postgres.

yosifkit avatar yosifkit commented on August 28, 2024

The reason for the change was #31 (pr #36). I made a note over there.

from postgres.

ToBeReplaced avatar ToBeReplaced commented on August 28, 2024

I am upset over how this was handled.

I had a long running 9.3 container, dumped the database, then tried to restore the database on a new host running a fresh container. I run with icc=False and was relying on postgresql not applying its own security. I was not able to proceed with 9.4, and the offending changes appear to have been back applied to 9.3, so when I pull a new 9.3 image it doesn't match my previous one.

Thus, I can no longer use previously known working code. This should never happen.

from postgres.

java-artisan avatar java-artisan commented on August 28, 2024

Why not provide an option to let people chose ?

from postgres.

yosifkit avatar yosifkit commented on August 28, 2024

This has been reverted in the most recent change. We were trying to fix "security", but went more than people were expecting.

from postgres.

workmaster2n avatar workmaster2n commented on August 28, 2024

Can I ask why this change was reverted? I understand that the change broke formerly working code, but I was a big fan of the change. I'm used to a postgres setup (non-docker) that requires some configuration in order to access and was really surprised when I found that trust line. I understand that I can configure a password or ship in my own pg_hba.conf, but I also ran a couple test containers with the -P flag thinking they were in no real danger. Also, the tutorials I was following ran the container with the -d flag, so my logs weren't shown on the console.

I do appreciate that with the trust enabled, someone getting into docker and postgres for the first time would have fewer technical hurdles to address (either modifying pg_hba.conf or providing a password), but I'm wondering if features like that should be included in an image flagged demo or insecure or some other indication of maybe-not-perfect-for-production.

I understand that if I don't expose the container to the outside world, the trust doesn't really matter, but in my configuration I was planning on having outside access so I could use command line tools to administer my database. At that point would it make sense to run postgres in a non-docker environment? Probably. But I figured if I was dockerizing part of the app, why not do the whole thing?

Is there a discussion group or something where we can keep all the talk on issues like this centralized? I'd love to just stay abreast of what different parties were saying and help out where I can. I noticed this was also discussed in issue #31 and pr #36 and I might be missing some other comments.

from postgres.

ndarilek avatar ndarilek commented on August 28, 2024

from postgres.

yosifkit avatar yosifkit commented on August 28, 2024

It was only partially reverted, if you provide a POSTGRES_PASSWORD the authentication from the pg_hba.conf will still be md5 but will not be restrictive on user, so that you can add more users and not be restricted by the pg_hba.conf.

from postgres.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.