h-links issue about x-links

[dnsev-h]

I've heard this is an issue but I have not experienced it myself. Let's see if you can get me some additional details on the problem:

• Browser and version number
• Userscript manager and version number
• 4chan-x and version number
• Do you have any additional scripts/extensions enabled
• Would you be willing to export your 4chan-x settings so that I may test with them?
• Also, does it put an [Ex] tag next to links, or is this missing as well?

[dnsev-h]

Just going to assume this has been fixed at this point, since so many changes have occurred since.

[dnsev-h]

For anyone who also gets this issue, try and give me the following information:

• Does an [Ex] tag appear next to links that don't work
• Are the links formatted with the gallery title, or is it still the URL

---

Also, open the dev console (CTRL+SHIFT+K in firefox, CTRL+SHIFT+J in chrome) and open the DOM inspector tab:

Right click the broken link and Inspect Element, and screencap the entire post's source in the DOM inspector (see pic); start from a a line containing

<div id="..." class="postContainer ...">

and continue til its closing </div> tag.

Additionally, if any of the x-links appearing in this view have the small ev bubble, click on them to show the events and screencap a pair of them as well. The tags should start with:

<a class="xl-site-tag ...">
and
<a class="xl-link ...">

Should look similar to this

[shamoke]

You asked me to post here so as not to clutter the thread so here I am. Hopefully these screenshots give you the info you needed. I still have the old thread with the broken stuff open in case I missed anything or misunderstood.

There was an error when trying to attach the files so have an imgur gallery instead. http://imgur.com/a/sYoUc

[dnsev-h]

Alright thanks, everything you posted is more than I wanted.

From what it looks like, all of the links are formatted properly with the proper amount of events.

And so you say that hovering over these links did not create any details display? Also, does/did clicking on the [Ex] tag itself open up a menu, open up the gallery in a new tab, or do nothing?

[shamoke]

Yea hovering over the link does nothing at all. Opening the gallery works fine, and refreshing the thread fixes the no hover problem. Went through the latest 100+ posts in the recent thread and this is the only one that was broken.

clipboard02
clipboard04
clipboard06

That bottom ev looked the same as the last one so I posted the one right above it since it looks like it might be part of the same thing. Too big to screenshot the whole thing since I can't resize those little windows so hopefully I'm pasting it here properly.

var gallery_toggle_actions = function(event) {
  if ($.is_left_mouse(event) && config.actions.enabled) {
    event.preventDefault();

    var index = this.getAttribute("xl-actions-index"),
      actions, tag_bg, data, link, id;

    if (!index) {
      index = "" + actions_nodes_index;
      ++actions_nodes_index;
      this.setAttribute("xl-actions-index", index);
    }

    if (this.classList.toggle("xl-site-tag-active")) {
      // Create bg
      tag_bg = $(".xl-site-tag-bg", this);
      if (tag_bg === null) tag_bg = create_tag_bg(this);

      // Show
      actions = actions_nodes[index];
      if (actions !== undefined) {
        actions.classList.remove("xl-actions-hidden");
        Popup.hovering(actions);
        activate_actions(actions, index);
      } else {
        // Create
        if (
          (link = get_link_from_tag_button(this)) !== null &&
          (id = get_node_id(link)) !== null &&
          (data = API.get_data(id[0], id[1])) !== null
        ) {
          actions = create_actions(data, link, index);
          actions_nodes[index] = actions;
          activate_actions(actions, index);
        } else {
          return;
        }
      }

      // Position
      update_actions_position(actions, this, tag_bg, d.documentElement.getBoundingClientRect());
    } else {
      // Hide
      actions = actions_nodes[index];
      if (actions !== undefined) {
        close_actions(actions, index);
      }
    }
  }
}

Almost missed that last part, this is what happens when clicking on the [ex]
clipboard08

[dnsev-h]

The source code of the events wasn't really necessary, I was more just interested in knowing if the events existed.

So it looks like the hovering elements aren't working properly. I'm hoping this is a styling issue.

Could you try doing the following?

• Open the DOM inspector and find an element that looks like:
  <div class="xl-hovering-elements">
  It should appear very close to the bottom.
• Expand the node so you can see its children
• Hover over the broken link and see if any of them change. (the class/style attributes should change) If one of them does, expand it. Screencap what you get.
  example
• Additionally, if this node does exist, screencap the styles of that node on the right.
  example

[shamoke]

Hovering over the broken link changes nothing in that area. Hovering over working links seems to highlight things in that area and they all appear to be in the order they were posted in the thread, so I hovered over the working links right above and below the broken one and there is nothing in between the 2 things that they highlighted.

clipboard08
clipboard10
clipboard12
clipboard14

[dnsev-h]

Okay that's odd. It seems that the nodes are either not being added to the page, or something is removing them.

Could you export your 4chan-x settings and post them here? (there's an "Export" link under the 4chan-x settings)

If that doesn't help me, I might have to whip up a version to debug this.

[shamoke]

https://mega.nz/#!ec8EhS6Q!953HK-6zc3QOfeTMrBojFcLRmfpK7YCEDMusnchqRaI

[dnsev-h]

Alright, I'll test with this for a bit to see if I can experience any problems.

[dnsev-h]

Okay so I've released a new version, 1.2.1 which includes some debugging stuff related to the error you've been getting.

To enable, first update, then open settings and enable debugging (at the bottom.) Then reload whatever pages and wait until you get any more problems.

When you do, open the dev console again and check for any lines starting with either:
X-links 1.2.1: Invalid link or X-links 1.2.1: Invalid details
Next to this text, there should be some additional info that looks like Object { ... }
Click on the Object text to show the info in the side and expand as much as you can, ignoring anything named __proto__ or is a dimmer color.

Screencap anything you get when this happens. Hopefully this should tell me what's going wrong and where. (It might not tell me why, but that's somewhat less important.)

[shamoke]

Is there something I'm missing that would let me expand everything at once and then copy the text? If I tried to expand everything within these even ignoring the proto stuff it would take several hours and be several hundred screenshots.

clipboard16
clipboard02
clipboard04
clipboard06
clipboard08
clipboard10
clipboard12
clipboard14

[dnsev-h]

Shoot, I should have clarified what to expand. I should have said I only needed the info one expanded.

The info you've provided me with basically tells me where the error is coming from, now I just have to figure out why. It seems to be an issue coming from the script not storing the gallery data properly.

One last thing that could help me: open up the dev console and copy and run this command:

console.log(JSON.stringify(window.localStorage));

After running, a new line of text should appear. Click any […] that appears to expand it fully, and copy it and paste it to a text file and upload. It will probably be fairly long.

Thank you for your cooperation, I hope to solve any issues you've been having soon.

[dnsev-h]

Actually, scratch that, I think I may have found where the issue is coming from. If this actually turns out to be where your problem is coming from, I feel like an idiot because it's such a simple fix.

[dnsev-h]

Alright, I have released version 1.2.1.1. Please update and let me know if you still experience any problems.

[shamoke]

Well I went through a full thread without it happening so it's probably fixed, but who knows since it only showed up at random before. Thanks for the support, I'll let you know if it comes back.

[dnsev-h]

It wasn't truly random before, it was because I was changing some things in the script that weren't outwardly visible. I might break it again in the future, but until then, I'll consider it fixed.