Coder Social home page Coder Social logo

Comments (11)

SCullman avatar SCullman commented on July 28, 2024 3

It's starting to feel like a family reunion here.

  • The link was html encoded, which makes no sense and breaks any following querystring parms.
  • If the type is URL, it should never ask for tracking. But it should do for type download.

from dnn.formandlist.

SCullman avatar SCullman commented on July 28, 2024

@sleupold , thank you for reporting!
Do you want to try to fix the issue? 🙏 Of course I can help you along the way, but most of the code and concepts should still be familiar to you.

from dnn.formandlist.

sleupold avatar sleupold commented on July 28, 2024

@SCullman atm i am not sure, whether it is a FnL issue or a feature ripped out of DNN platform. Still investigating.

from dnn.formandlist.

SCullman avatar SCullman commented on July 28, 2024

@sleupold I am quite sure it is a bug.
See here, url is unmodified (and just empty) if it is set to Url and tracking.
And there are no extra actions taken for any other link type to enable tracking.

from dnn.formandlist.

sleupold avatar sleupold commented on July 28, 2024

@SCullman other data types are using linkclick.aspx handler, but do not count clicks either.
I am travelling atm, will have a look nect but one week.
PS: I encountered the issue, while trying to support another community member.

from dnn.formandlist.

SCullman avatar SCullman commented on July 28, 2024

Well, this is fixed. But shouldn't the download number appear anywhere? I cannot remember.

from dnn.formandlist.

SCullman avatar SCullman commented on July 28, 2024

Ok, with DataType LookUp and token [File:Clicks].
The urlController is always initialized with false , as the setting URLDownloadTrackingis not set anywhere, AND it should be controlled by the proper field setting.

from dnn.formandlist.

vmasanas avatar vmasanas commented on July 28, 2024

I have a similar issue if you just select a file, not a url.
In this case a link limilar to this is generated:

<Document_UDT_Url>/LinkClick.aspx?fileticket=ORvcmU6B_Us%3d&tabid=3708&portalid=0&mid=10056</Document_UDT_Url>

The problem is that on DotNetNuke.Services.FileSystem.FileServerHandler, line 71 this will not correctly identify the mid or tabid parameters so any tracking fill fail.

if (context.Request.QueryString["mid"] != null)
{
Int32.TryParse(context.Request.QueryString["mid"], out ModuleId);
}

BTW, if you select a File, not a URL, should not it also ask for tracking?

from dnn.formandlist.

SCullman avatar SCullman commented on July 28, 2024

New release 6.5.4 available for testing.
@sleupold , @vmasanas Thank you for reporting and commenting, is was indeed helpful.

from dnn.formandlist.

vmasanas avatar vmasanas commented on July 28, 2024

@SCullman I installed the new version of the module but I still see the url has the same format as before.
The link I see there is
..../LinkClick.aspx?fileticket=jbdt2JJoHbA%3d& amp; tabid=3708& amp; portalid=0& amp; mid=10056

am I missing something here?

from dnn.formandlist.

SCullman avatar SCullman commented on July 28, 2024

@vmasanas Can't reproduce. I see links like
/LinkClick.aspx?fileticket=wX7FnQbzE18%3d&tabid=33&portalid=0&mid=381&language=en-US
And I double checked and verified that the correct assembly (tagged with fileversion 6.5.4) is both in my bin and in release.

Btw, if you test with old data:

  • Ensure Track Number of Downloads is enabled for the filed of type url
  • You need to edit and save the row, otherwise the file/ url is not regstered for tracking.

from dnn.formandlist.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.