Comments (7)
Decided to store 'is_test' and 'is_public' as separate boolean values to the projects table rather than as a value from a separate 'visibility_types' table like we have in the DMPTool codebase.
A plan can have the following visibilities:
- Test - visible only to the owner and specified collaborators
- Public - the plan will be available on the new Public DMPs page and accessible/exportable by anyone
- Organisational - the plan is neither Test or Public and is available to the owner, collaborators and admins
I'm handling the logic to prevent a plan from being marked as both public and test at the same time in the model and UI code.
Took an initial stab at the UX workflow for this and the new 'test' flag (see screenshots).
from roadmap.
Decided to switch to a visibilities table after discussion with @stephaniesimms. There are some nuances between making a plan 'test' and 'private' so we will need 4 visibility settings: test, private, organisational (default) and public
from roadmap.
related to #84
from roadmap.
adding reference to Pivotal ticket for test flags: https://www.pivotaltracker.com/story/show/120867001
Objective is to mark test plans to separate them from usage stats. Possible ways to do this:
- add button/check box in Create plan workflow to mark test plans
- add button on Confirm plan details page (currently Create plan, Cancel options)
- test plan can be copied as a real plan or reclassified on My Plans page
- test plan cannot be exported
from roadmap.
Added test checkbox to view plans table. Only owners and coowners can change whether or not a plan is designated as a test. Making a plan 'test' will automatically change the visibility to 'Private' in the UI (the test flag is treated the same as the other visibilities in the database)
Also added the new 'create test plan' link which will bring the user to the create plan page.
I also added a configurable default visibility setting to the application.rb
file. A new plan is automatically set to 'private' visibility. This can be overriden though for each installation.
When the user clicks 'create test plan' they will see the following:
from roadmap.
test flag functionality works as expected. I can either create a Test plan at the outset, or tick the "Test" box in My plans or Plan details pages, which defaults the plan to private visibility. moving this issue along.
from roadmap.
Looks good. Can create a test plan from scratch and easily adjust setting in table. This seems to autosave as just need to check box and entry is retained, which fits well with how we're implementing it elsewhere. Good to close out.
from roadmap.
Related Issues (20)
- PR 3105 reverse for pagination? HOT 14
- Docker? HOT 9
- [FEATURE] Disable mandatory account creation when signing in with institutional credentials. HOT 2
- Disable debug checking for rubocop >=1.45.0 HOT 2
- Flash warning `Error: Record Not Found: Couldn't find Template without an ID` somewhere after visiting `/plans` HOT 1
- Message of `No questions have been answered for this DMP` or `Rest of the DMP hasn't been completed yet.` should be added when export a uncomplete plan
- [FEATURE]: Retain hmtl code when downloading to pdf
- Removing question_option in admin template triggers a full reload
- Google tracker code in org admin edit page has no effect when root organisation has none HOT 1
- Error while integrate with Keycloak OpenID Connect HOT 10
- [BUG]: Formatting errors in Word download
- [BUG]: formatting errors in PDF download
- [FEATURE]: Allow admins to delete a template HOT 6
- Notify researchers when there is an updated version of a template
- Migrate off of FlagShihTzu gem
- Migrate away from the WickedPdf gem and WkHtmlToPdf package
- New CSSBundling compilation fails in production
- API internal server error 500 HOT 3
- ruby gem `spring` is required by command `bin/rails`, even in production environment HOT 2
- Latest version of better_errors triggers "cannot load such file -- sassc (LoadError)" HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from roadmap.