Coder Social home page Coder Social logo

Comments (6)

DmitryTsepelev avatar DmitryTsepelev commented on May 24, 2024

🤦‍♂ I guess I know where it comes from - investigating

from store_model.

majksner avatar majksner commented on May 24, 2024
[27] pry(main)> machine = Machine.new(project_id: 1, configuration: nil)
=> #<Machine:0x00007fdeae95dfc8
 id: nil,
 project_id: 1,
 configuration: nil>
[28] pry(main)> machine.save!
   (0.3ms)  BEGIN
   (0.3ms)  ROLLBACK
StoreModel::Types::CastError: failed casting nil, only String, Hash or MachineConfig instances are allowed
from /Users/test/.rvm/gems/ruby-2.6.3/gems/store_model-0.3.0/lib/store_model/types/json_type.rb:22:in `cast_value'

from store_model.

DmitryTsepelev avatar DmitryTsepelev commented on May 24, 2024

@majksner Thank you for catching this! Just released 0.3.1 with the fix according to your suggestion

from store_model.

majksner avatar majksner commented on May 24, 2024

You're welcome, I could still see one problem and that is we don't check if allow_nil: true is set anywhere in the code.

from store_model.

DmitryTsepelev avatar DmitryTsepelev commented on May 24, 2024

In this case we use a regular ActiveRecord validation, and allow_nil is shipped out of the box

from store_model.

majksner avatar majksner commented on May 24, 2024

👍🏻 Thanks for the such a quick fix!

from store_model.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.