Coder Social home page Coder Social logo

Comments (4)

DmitryTsepelev avatar DmitryTsepelev commented on May 23, 2024

Hi @kaelumania!

It's not possible right now: there is no way to build polymorphic types and let gem know how to decide what type should be used.

It could work like this (we define polymorphic type and use it in model):

# regular model definition
class Product < ApplicationRecord
  attribute :configuration, Configuration.to_array_type
end

class ConfigurationV1
  include StoreModel::Model

  # ...
end

class ConfigurationV2
  include StoreModel::Model

  # ...
end

class Configuration
  include StoreModel::PolymorphicModel

  def self.resolve(json)
    json[:version] == '1' ? ConfigurationV1 : ConfigurationV2
  end
end

In order to add the support we need to implement StoreModel::PolymorphicModel and handle it in ArrayType#cast_value

Please let me know if you want to try it out and I'll be happy to help ๐Ÿ™‚

from store_model.

kaelumania avatar kaelumania commented on May 23, 2024

Thanks for the fast response :) it don't have to be an array type though. I would suggest to use the same naming as for single table inheritance in active record json[:type]. What do you think about:

# regular model definition
class Product < ApplicationRecord
  attribute :configuration, Configuration.to_type, polymorphic: true
end

class ConfigurationV1 < Configuration
  # ...
end

class ConfigurationV2 < Configuration
  # ...
end

class Configuration
  def self.resolve(json)
    find_subclass(json[:type])
  end
end

from store_model.

DmitryTsepelev avatar DmitryTsepelev commented on May 23, 2024

Yeah, it definitely should work with a singular associations too. attribute method is a part of Rails Attributes API so it's hard and errorโ€“prone (in future) to add params to it, that's why I try to pack the logic into the type class as much as possible ๐Ÿ™‚ Maybe we could allow to build resolve dynamically (by the way, I think it's not even required to be a subclass):

class Product < ApplicationRecord
  attribute :configuration, StoreModel.polymorphic { |json| "#{json.type}".constantize }
end

from store_model.

DmitryTsepelev avatar DmitryTsepelev commented on May 23, 2024

Added in #61

from store_model.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.