Coder Social home page Coder Social logo

Comments (3)

DmitryTsepelev avatar DmitryTsepelev commented on May 24, 2024

Hi @FunkyloverOne!

Thanks for the reaching out, I like the idea! Let's design the API for it 🙂

I think it should be possible to patch the .attributedefinition to accept preserve: argument:

class Site
  class Settings
    include StoreModel::Model

    attribute :twitter_handle, :string
    # ...

    attribute :colours, ColourScheme.to_type, default: -> { ColourScheme.new }, preserve: true
    attribute :style, Styling.to_type, default: -> { Styling.new }, preserve: true
    attribute :footer_pages, FooterPage.to_array_type, default: -> { [] }
  end
end

In this case #assign_preserving can be moved to StoreModel::Model, and we should also make sure that if preserve: true is passed than type is either JsonType or ArrayType. What do you think?

from store_model.

FunkyloverOne avatar FunkyloverOne commented on May 24, 2024

Hey @DmitryTsepelev, one important thing is that we also need to have that #assign_preserving on a parent ActiveRecord model.

Arrays preservation is not that easy as singular JSONs. You see, we need a way of identifying each individual element, updating/removing it, adding new ones. It is supposed to be similar to ActiveRecord's accepts_nested_attributes_for API.

But we could start without arrays preservation support, it's already good enough 😄

from store_model.

DmitryTsepelev avatar DmitryTsepelev commented on May 24, 2024

Makes sense. We should probably change the name to something that can be easily associated with StoreModel (like assign_preserving_nested_store_models but less verbose)

from store_model.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.