Comments (3)
Hi @FunkyloverOne!
Thanks for the reaching out, I like the idea! Let's design the API for it 🙂
I think it should be possible to patch the .attribute
definition to accept preserve:
argument:
class Site
class Settings
include StoreModel::Model
attribute :twitter_handle, :string
# ...
attribute :colours, ColourScheme.to_type, default: -> { ColourScheme.new }, preserve: true
attribute :style, Styling.to_type, default: -> { Styling.new }, preserve: true
attribute :footer_pages, FooterPage.to_array_type, default: -> { [] }
end
end
In this case #assign_preserving
can be moved to StoreModel::Model
, and we should also make sure that if preserve: true
is passed than type
is either JsonType
or ArrayType
. What do you think?
from store_model.
Hey @DmitryTsepelev, one important thing is that we also need to have that #assign_preserving
on a parent ActiveRecord
model.
Arrays preservation is not that easy as singular JSONs. You see, we need a way of identifying each individual element, updating/removing it, adding new ones. It is supposed to be similar to ActiveRecord
's accepts_nested_attributes_for
API.
But we could start without arrays preservation support, it's already good enough 😄
from store_model.
Makes sense. We should probably change the name to something that can be easily associated with StoreModel
(like assign_preserving_nested_store_models
but less verbose)
from store_model.
Related Issues (20)
- Validate any Hash HOT 1
- Encrypt attributes HOT 2
- Aliasing an attribute HOT 1
- GraphQL input type fails to cast HOT 4
- ArgumentError: wrong number of arguments (given 1, expected 0) in random model HOT 3
- Assignment Doesn't work in OneOf case HOT 3
- Delegation of `fetch` to `attributes` causes issues HOT 2
- NameError: uninitialized constant StoreModel::Types::ArrayType HOT 3
- Default values for attributes when retrieving the store model HOT 1
- Decoding Custom Types HOT 1
- Allow an option to disallow "UnknownAttributes" behavior HOT 1
- ActiveRecord validation contexts don't propagate HOT 1
- Override methods HOT 3
- Broken defaults in 2.0 HOT 2
- Attribute encryption with ActiveRecord::Encryption HOT 1
- StoreModel Stringifying json when saving. HOT 14
- accepts_nested_attributes_for allow partial updates HOT 2
- [QUESTION] How preserve data on update? HOT 1
- JSON deserializing empty string, leads to nil error
- Optional tracking of parent functionality HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from store_model.