Coder Social home page Coder Social logo

Comments (3)

DmitryTsepelev avatar DmitryTsepelev commented on May 23, 2024 1

Rolled out 0.5.0, it took a bit more time than I expected

from store_model.

DmitryTsepelev avatar DmitryTsepelev commented on May 23, 2024

Hi @FunkyloverOne,

Thank you for the interest! Your idea sounds pretty reasonable, let's discuss how we can make this change. The problem is that I use #attributes from Rails and there is no way to add a custom attribute without hackery because

def attributes
  @attributes.to_hash
end

I believe the situation you describe is not a "golden path" and user knows what's going on, so it won't bother him to look up for the "lost" attribute somewhere elseโ€“what about #unknown_attributes method? Here is my proof-of-concept PR, there are no docs (yet!) but there is a spec and the code, what do you think? ๐Ÿ™‚

from store_model.

FunkyloverOne avatar FunkyloverOne commented on May 23, 2024

Hey @DmitryTsepelev,

I like it! Thanks for such a quick reply and PR! #unknown_attributes method is totally reasonable to me :)

from store_model.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.