Coder Social home page Coder Social logo

Comments (11)

dmarcuse avatar dmarcuse commented on September 26, 2024

Sure thing! I'm planning on adding an export dialog to allow tweaking what's included and how, so this seems like a natural addition. Do you have any other specific details in mind - i.e. do you want to preserve the directory structure as well, or just the filename?

from fvtt-adventure-bundler.

Cybsjan avatar Cybsjan commented on September 26, 2024

Oeh! That's a good question. Directory structure would be a logical thing as well to include.

from fvtt-adventure-bundler.

Cybsjan avatar Cybsjan commented on September 26, 2024

I forgot to mention that this module is wonderful for a community I'm in. We've been struggling to share updates to a shared world to each other and now with this module, it gets a whole lot easier.

from fvtt-adventure-bundler.

dmarcuse avatar dmarcuse commented on September 26, 2024

I'm glad to hear that!

from fvtt-adventure-bundler.

sauleve avatar sauleve commented on September 26, 2024

Wonderful stuff. Would second the idea of an option to let me rename all assets from wherever in the Foundry hierarchy to asset(x), maybe a 3 checkbox for also rename Foundry / modules / URLs maybe under subfolder adventure-name but you might need a copyright disclaimer to the effect "I confirm I have the right to share/distribute this content with who I distribute the adventure to".

from fvtt-adventure-bundler.

dmarcuse avatar dmarcuse commented on September 26, 2024

There's already a setting to include module files (with a copyright disclaimer), but I'm not sure about offering settings for including core Foundry files or files from URLs. In the case of Foundry files, these should always be available by default anyways - there isn't really any benefit to bundling them.

from fvtt-adventure-bundler.

sauleve avatar sauleve commented on September 26, 2024

There's already a setting to include module files (with a copyright disclaimer), but I'm not sure about offering settings for including core Foundry files or files from URLs. In the case of Foundry files, these should always be available by default anyways - there isn't really any benefit to bundling them.

Yes, I hadn't seen that setting, thats great, even better than I hoped. I was thinking it would be a way of having the zip still work if the location of the foundry assets changed, but maybe their asset hierarchy will remain unchanged through the versions.

from fvtt-adventure-bundler.

dmarcuse avatar dmarcuse commented on September 26, 2024

I would be surprised if Foundry asset locations changed as it would potentially break a lot of modules. There is actually a hidden setting already implemented in the module to bundle core foundry assets, but it's mostly intended for debugging. If you really want to include them anyways, you can open your Foundry world and press F12 (or otherwise open the developer tools in your browser) and enter the following snippet of code to enable it for the current world:

await game.settings.set("adventure-bundler", "bundleAssetCoreFile", true)

I don't recommend this since it unnecessarily duplicates asset files that are already in Foundry, and could run into copyright issues though. If you want to disable it, paste in this snippet:

await game.settings.set("adventure-bundler", "bundleAssetCoreFile", false)

from fvtt-adventure-bundler.

yorkshirelandscape avatar yorkshirelandscape commented on September 26, 2024

I was just thinking of forking the project to preserve filenames myself, but might be getting in over my head. Any progress on this front?

from fvtt-adventure-bundler.

dmarcuse avatar dmarcuse commented on September 26, 2024

Unfortunately not, I haven't had the time to refactor the project like I was hoping. If you do fork the project, I'm happy to offer input into how it works under the hood, and review PRs if you were hoping to merge them back upstream.

from fvtt-adventure-bundler.

yorkshirelandscape avatar yorkshirelandscape commented on September 26, 2024

Thanks, I'll take you up on that sometime soon.

from fvtt-adventure-bundler.

Related Issues (11)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.