Coder Social home page Coder Social logo

Comments (5)

rudolfix avatar rudolfix commented on September 26, 2024

we just got an update: for natively specified file paths to local filesysten ie C:\my\path if the path does not exist there's no error message. if the path exists the pipeline does not see any files. so certainly something is wrong here

from dlt.

IlyaFaer avatar IlyaFaer commented on September 26, 2024

@rudolfix, okay, I think I reproduced it:

image

Figuring out what's wrong there.

from dlt.

IlyaFaer avatar IlyaFaer commented on September 26, 2024

@rudolfix, I wonder what's the meaning of this line:

bucket_url_no_schema[2:] if bucket_url_no_schema.startswith("//") else bucket_url_no_schema

from dlt.

rudolfix avatar rudolfix commented on September 26, 2024

@IlyaFaer this strips leading "//" from the front but IDK why.
I think this part:

# make that absolute path on a file://
        if bucket_url_parsed.scheme == "file" and not file.startswith("/"):
            file = f"/{file}"
        file_name = posixpath.relpath(file, bucket_url_no_schema)
        file_url = bucket_url_parsed._replace(
            path=posixpath.join(bucket_url_parsed.path, file_name)
        ).geturl()

destroys some of the local paths
you'll need to debug that more

from dlt.

IlyaFaer avatar IlyaFaer commented on September 26, 2024

@rudolfix, yes, I brought a couple of fixes into your code, but I see that fsspect package code is also breaking the path in some way. Checking what's wrong there yet...

from dlt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.