Values of bit type are read incorrectly about pypyodbc

[GoogleCodeExporter]

Just re-tested it on Linux, with both native microsoft driver and FreeTDS. The 
same thing happens, so the problem is certainly in pypyodbc code.

Original comment by [email protected] on 5 Jul 2013 at 4:46

[GoogleCodeExporter]

I think I found the bug. This will be one character fix.

In pypyodbc.py in line 578, instead of

  lambda x:x=='1'

should be:

  lambda x:x==b'1'

Can somebody do an official code fix?

Original comment by [email protected] on 5 Jul 2013 at 5:43

[GoogleCodeExporter]

Hi, Thanks for reporting this and the fix.
I have updated the source code in GitHub:

https://github.com/jiangwen365/pypyodbc/blob/master/pypyodbc.py

Original comment by [email protected] on 6 Jul 2013 at 2:37

• Changed state: Fixed

[GoogleCodeExporter]

Sorry, your fix does not work in Python3. You effectively call:
   bytes('1')
which gives an error:
   TypeError: string argument without an encoding
I guess, you did not try the fix in Python3.

If you use bytes() function, it should be bytes('1', 'ascii')
I understand it is a little tricky to support both Python2 and Python3.
For me, the "b'1'" worked fine. Can you try it in Python2? If it works, then 
you can fix it the way I suggested. 

Original comment by [email protected] on 8 Jul 2013 at 4:29

[GoogleCodeExporter]

Or you can simply fix the line 42 like this:

       str_8b = lambda s: bytes(s, 'ascii')

Original comment by [email protected] on 8 Jul 2013 at 4:44

[GoogleCodeExporter]

Hi, yes, that does work, I have updated the source code in GitHub:

https://github.com/jiangwen365/pypyodbc/blob/master/pypyodbc.py

Can you try again and see if it works?

Original comment by [email protected] on 9 Jul 2013 at 1:29

[GoogleCodeExporter]

I already tried this by fixing the code in my own copy of the module.

Original comment by [email protected] on 9 Jul 2013 at 12:16

[GoogleCodeExporter]

fixed in version 1.1.5

Original comment by [email protected] on 11 Jul 2013 at 12:04