Comments (3)
Maybe I'm missing something or maybe something else changed that fixed the
problem you saw. It looks like it's creating all of the stored procs to me.
diff --git a/tests/test_sprocs.py b/tests/test_sprocs.py
index 9575269..c1cf65a 100644
--- a/tests/test_sprocs.py
+++ b/tests/test_sprocs.py
@@ -289,6 +289,7 @@ class TestStringTypeConversion(object):
'name': name,
'identifier': identifier
})
-
print('**\* Created stored proc: [pymssqlTest%(name)s]' %
{'name': name})
except:
if name == 'Text':
raise
@@ -296,6 +297,7 @@ class TestStringTypeConversion(object):
def tearDown(self):
for name, size in VARIABLE_TYPES:
self.mssql.execute_non_query('DROP PROCEDURE [dbo].[pymssqlTest%s]' % name) -
print('*** Deleted stored proc: [pymssqlTest%(name)s]' % {'name':
name})
self.mssql.close()def testChar(self):
marca@marca-mac:~/dev/git-repos/pymssql$ .tox/py26/bin/nosetests -s -v
tests.test_sprocs:TestStringTypeConversion
tests.test_sprocs.TestStringTypeConversion.testChar ... *** Created stored
proc: [pymssqlTestChar]
*** Created stored proc: [pymssqlTestText]
*** Created stored proc: [pymssqlTestVarChar]
*** Deleted stored proc: [pymssqlTestChar]
*** Deleted stored proc: [pymssqlTestText]
*** Deleted stored proc: [pymssqlTestVarChar]
ok
tests.test_sprocs.TestStringTypeConversion.testText ... *** Created stored
proc: [pymssqlTestChar]
*** Created stored proc: [pymssqlTestText]
*** Created stored proc: [pymssqlTestVarChar]
*** Deleted stored proc: [pymssqlTestChar]
*** Deleted stored proc: [pymssqlTestText]
*** Deleted stored proc: [pymssqlTestVarChar]
ok
tests.test_sprocs.TestStringTypeConversion.testVarChar ... *** Created stored
proc: [pymssqlTestChar]
*** Created stored proc: [pymssqlTestText]
*** Created stored proc: [pymssqlTestVarChar]
*** Deleted stored proc: [pymssqlTestChar]
*** Deleted stored proc: [pymssqlTestText]
*** Deleted stored proc: [pymssqlTestVarChar]
ok
Ran 3 tests in 0.227s
OK
So it seems like it's doing everything it's supposed to?
(It's kind of weird and slightly inefficient that it creates and deletes all 3
stored procs for all 3 tests -- each test could create and delete just the one
it needs -- but that's another issue)
Let me know if you think this patch is still relevant...
Original comment by [email protected]
on 2 Mar 2013 at 1:46
from pymssql.
Hmm In tested this a while back using SQL Server 2000.
Only thing I remember is that it failed when trying to create the SP for the
TEXT data type and then the `except` block was executed and the loop over
VARIABLE_TYPES aborted, etc.
Could it be that such SQL Sever version didn't support TEXT as an input and/or
output stored procedure parameter?
Please feel free to close this issue.
BTW, Which is the minimal supported SQL Server version?
Original comment by [email protected]
on 6 Mar 2013 at 2:46
from pymssql.
OK, well I don't have SQL Server 2000 so I can't verify that's the cause, but
hey, that change is so innocent that I just went ahead and made it so that the
TEXT stored proc test runs last like you had it.
https://code.google.com/p/pymssql/source/detail?r=101d23ff5710b57b599ffc0ef1171a
e5160aebe0
I'll close this issue.
Not sure what the minimal supported SQL Server version is. rsyring might know...
Thanks, Ramiro!
Original comment by [email protected]
on 3 Apr 2013 at 5:32
- Changed state: Fixed
from pymssql.
Related Issues (20)
- Failure to pass Unicode characters to callproc; failing test: tests.test_sprocs.TestCallProcFancy.testCallProcWithUnicodeStringWithRussianCharacters HOT 7
- When pymssql.connect() - DB-Lib error message 20002, severity 9;Adaptive Server connection failed HOT 1
- Fix test_config.py typos. HOT 1
- Small fix about TDS protocol version in a comment HOT 1
- Fix SP name handling in threaded test so we can actually run it. HOT 2
- Feature for discussion (with patch): pymssql_shell HOT 2
- A few tests fail if running on a system that has SQL Server available on port 1433 HOT 1
- add function for getting FreeTDS version HOT 1
- datetime conversion to sql is not converting sub-seconds correctly HOT 5
- memory leaks (patches included) HOT 24
- pymssql-2.0.0b1-dev-20130403.tar.gz doesn't compile due to /usr/bin/ld: cannot find -lct HOT 8
- Installer issue HOT 1
- error: unrecognized command line option "-Wno-parentheses-equality" HOT 8
- pymssql.so: undefined symbol: __fread_chk HOT 5
- Support "with" statement (PEP 343) HOT 5
- Can't compile on OS X 10.8.4 HOT 10
- Review pymssql result processing code
- Make Cython not necessary when pymssql.c and _mssql.c are already present HOT 1
- IOError: [Errno 2] No such file or directory: 'ChangeLog_highlights.rst' HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pymssql.