Unable to find the `gcloud` command on Windows about gcp_auth

[andreban]

Oh, indeed, I can see which was still there in 0.12.0. I can confirm it fails to find the gcloud command on 0.12.0 though. I'll keep looking into why it fails to find it.

[djc]

Sounds great, can you submit a PR?

[djc]

Do you want to try to revert #109 and see if that works for you? (I think if the removal of which is the cause, 0.12.0 should work for you since IIRC I only removed that in in 0.12.1.)

[andreban]

Right, I wasn't pinning 0.12.0 correctly on my application's Cargo.toml. Once I pinned it correctly, the application worked. I confirmed this by checking out the 0.12.0 tag and running the simple example, then checking 0.12.1 and running the example. It succeeds on 0.12.0 and fails on 0.12.1. Re-adding the which code to 0.12.1 gets it working again. Happy to create a PR reverting the change, but wanted to check if there was another reason for removing the which dependency in the first place and other solution might be appropriate.

[djc]

I'm wondering, if you open a Command Prompt on Windows, can you successfully invoke Windows? I should probably also look at how which is implemented on Windows.

[djc]

I'm generally open to the idea of reverting the change that removed which but would like to understand why it's needed here. Maybe it could be a Windows-only dependency?

[andreban]

It does work on the command line.

It turns out the problem is not the path, but the executable name. The actual executable name on Windows is gcloud.cmd. While, on the Command Prompt simply calling gcloud works and gcloud.cmd is invoked, that doesn't seems to be the case when spawning a process with Rust's Command.

So, this makes it work:

let mut command = Command::new("gcloud.cmd");

I think just moving the command name to OS specific variable should work:

fn run(cmd: &[&str]) -> Result<String, Error> {
    let mut command = Command::new(GCLOUD_CMD);
    command.args(cmd);
...
}

...

#[cfg(any(target_os = "linux", target_os = "macos"))]
const GCLOUD_CMD: &str = "gcloud";

#[cfg(target_os = "windows")]
const GCLOUD_CMD: &str = "gcloud.cmd";

[andreban]

Created #113. Tested on Windows and MacOS.