Comments (31)
Alright, I'll make a pull request so you (and others) can add your comments on it for a merge.
from django-statsd.
I hope to get to it somewhere next week. Shouldn't be too much work anymore. Sorry for the delay.
from django-statsd.
Version 0.4.0 uploaded on pypi.
from django-statsd.
We've started our own fork here to keep up the pace with our internal development:
https://pypi.python.org/pypi/django-statsd-unleashed
It should support new versions of Django and Python. Maybe this can be of any help to you too.
from django-statsd.
Timing seems to be pretty bad here.
@Duologic why didn't you asked for the maintainer ship instead of forking ?
from django-statsd.
Things are in a good enough shape for a release. All the build are now green, tests are running smooth and browser side clients are working
from django-statsd.
I'm sorry, we've had pull requests open for quite some time without a response and didn't want to wait any longer. I'll happily make a new pull request.
Also, the docs state you've been looking for a new maintainer, that gave me the idea this project was halfway to being abandoned.
from django-statsd.
I've been working on raising the test coverage too and running it on multiple Django and Python versions, check it out here: vikingco#6
I'd love to work together getting it into upstream. However, I've made some decisions that might not fit the original project (ie. using py.test, dropping support for metlog-py, etc.). See this commit for a more complete list: vikingco@b74b739
from django-statsd.
@Duologic don't worry, it's my fault here.
I got the ownership like 2 days after you left the comment and I started to clean things up locally before looking at the issue list.
Just committed the work I started.
Would you be willing to join ?
from django-statsd.
using py.test, dropping support for metlog-py
Like I've set up tox & py.test and considering dropping metlog-py as it's deprecated in favor of a deprecated project too.
Looks like we have a match ;)
from django-statsd.
Let me first merge our branches into our master so we get a clear overview. I'll do that tomorrow when I'm at the office.
from django-statsd.
Had a quick look at you branch and looks like you did a nice job !
from django-statsd.
@Duologic mind if I pull your branch and start merging ?
from django-statsd.
I was just looking at merging our changes into yours and came over this pattern:
import django_statsd.views
#do something with "django_statsd.views.record"
I'm rather a fan of doing this:
from .views import record
# do something with "record"
What do you think?
from django-statsd.
That's ok for me as well.
from django-statsd.
I'm having some trouble with the complexity of the .travis.yml and I'm not really a fan of tox. So I made a branch that currently has a much simpler version of .travis.yml and runs pytest directly from Travis instead of via Tox.
Rebased on your changes: vikingco#7
Is there a good reason to support pypy and pypy ? I'm not very well known with those python binaries.
Feel free to leave some comments or suggestions.
from django-statsd.
I find tox is very useful for me to run the test matrix locally.
Whenever I want to skip all the overhead, I simply run .tox/py34-django111/bin/py.test
and get done
from django-statsd.
Wow, I was just about to ask if a new version could be posted to PyPI as well. Glad to see someone has taken control of this project and that the Django 1.11 issues have been ironed out 👍
Any idea on when the PyPI update will happen?
from django-statsd.
No ETA for now. I'd like to converge with @Duologic first.
from django-statsd.
@Duologic @xordoquy are you both still working on converging?
from django-statsd.
Cool, thanks for the update :)
from django-statsd.
Any updates here? :/
from django-statsd.
lots of personal things ongoing but will try to get this moving this week end.
from django-statsd.
Same here, fairly busy. If you want, pull in any changes that you like. When I find more time, I'll make smaller pull request for each feature
from django-statsd.
@xordoquy Any news?
from django-statsd.
It's ironic how this repo was taken over due to no maintenance, only to immediately end up back in the same situation...
from django-statsd.
@ownaginatious thanks for your contribution !
@michael-k still recovering from overload. Will try to get this fixed as soon as I can.
from django-statsd.
@xordoquy sorry for the undeserved snarky comment. It just seems like everything's stalled on things unrelated to this actual issue here.
I think it's great that there are improvements coming in around style and automated testing/coverage, but I don't think it should be blocking updates for Django compatibility. I actually had a PR to submit to fix the 1.9+ compatibility issues, but got rid of it when I saw you'd coincidentally taken over maintainership and fixed most of the issues already.
If seems to me that if PR #104 were to merge into master
, then at the very least, this library would work for Django 1.9, 1.10, 1.11 and (theoretically) 2.0.
Given that you and @Duologic seem very busy, that seems like the path of least resistance for getting a new PyPI version up, where the other improvements can be done later in separate PRs.
from django-statsd.
It already works with Django 1.11, we're using both django-statsd 0.3.16 and Django 1.11 on production (on Python 3.6). We're just annoyed by the long list of deprecation warnings that our test runs produce.
from django-statsd.
Whoops you're right; it's been a while and I got this confused with some of the other dependencies we submitted PRs to that did have breaking compatibility issues with Django 1.11.
We raise deprecation warnings to errors in our tests, so in the mean time we've been getting this dependency by commit hash from a fork of this repo in our builds where the deprecation warnings are fixed.
from django-statsd.
@xordoquy thanks, appreciate it 👍
from django-statsd.
Related Issues (20)
- readthedocs links are dead HOT 1
- Not connecting to Celery signals on Python 2 with v0.4 HOT 2
- Newest release doesn't include datadog
- Switch to a monotonic timer in middleware and celery integration
- Stop using `is_managed`, which is deprecated (and removed) in Django 1.6
- Document How To Run Tests HOT 1
- Incorrect gauge signature, confusion with required statsd version HOT 1
- requirements file should support more recent djangos HOT 1
- debug toolbar panel content not showing, django 1.6 + debug-toolbar 1.2 + django-statsd 0.3.12 HOT 1
- When there is an exception the middleware records response time twice HOT 2
- 0.3.13 Changes HOT 1
- Python 3 won't install unittest2 in requirements.txt HOT 3
- Incompatibilty with eventlet HOT 4
- statsd 3.1 breaks metrics collecting HOT 2
- Lock in statsd version (semver) HOT 1
- Syntax error installing django-statsd under Python 3 HOT 2
- Release new package with recent changes HOT 2
- Django 1.9 'WSGIRequest' object has no attribute 'REQUEST' HOT 1
- Travis CI no longer running on new commits HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from django-statsd.