Nullable ID field in IEntity interface about mongodb.entities

[dj-nitehawk]

it was introduced as a breaking change.

see here for the discussion we had regarding this.

that being said... i am finding having to the use the ! everywhere (just to get rid of the green squiggly line) in my projects is a bit tedious and doesn't make much sense. so i'm thinking about making the IEntity.ID non-nullable.

@dberry-rcs do you have any input on this?

[m-sokol-esky]

sorry, I thought it was introduced here (v22.1)

I agree, I had to add thousands of ! to fix all the errors and I think it is not worth it, seeing that 99% of times it will not actually be null.

[dberry-rcs]

it was introduced as a breaking change.

see here for the discussion we had regarding this.

that being said... i am finding having to the use the ! everywhere (just to get rid of the green squiggly line) in my projects is a bit tedious and doesn't make much sense. so i'm thinking about making the IEntity.ID non-nullable.

@dberry-rcs do you have any input on this?

I am okay with this. I typical create the ID upfront and don't wait for it to be added by the framework. Changing it to not null will require that the checks to see if the object has been saved will need to change. The framework will no longer be able to assume that having an ID means it has been saved. This would also allow us to remove GenerateNewID as the ID will be set from the constructor.

[dj-nitehawk]

completed in v23 release