Comments (2)
Here the thing is that this is the way it was implemented before. On the mail-merge.js code, the previous developer only compiles the previews on view load, and in some very specific instances where he manually called a refresh method that attempted to recompile the preview sections.
I haven't touched any of this because to be honest it is really bad coding on my opinion, and it uses a bunch of manual DOM manipulation through jQuery to achieve the current behavior. In my opinion all this is unnecessary and a better implementation could have being developed using more angular ways, using angular native bindings to update the previews as the model (form variables) changed, and without even using jQuery (which is a bad practice) at all.
Again all this was out of the scope of my project, and I could try to spend some time if needed on this, but I have already spent a week more than my estimates, and this will just add a lot more time just to pretty much rewrite the mail-merge component almost completely, and I was hoping to finish this up today since I need to move forward with other projects next week.
from the-app.
I don't understand. I tested this initially and it was interpolating while I type real time just fine (including onload first time).
Just took again the original old code now and I see that it is working fine all the above form fields get interpolated while I type real time just fine.
Feel free to git clone yourself the old repository and see it working fine.
from the-app.
Related Issues (20)
- backend-apis-should-get-executed-only-when-required HOT 2
- corrupt-zip-file-when-downloading HOT 2
- remove-existing-jobs-test-data-seeding
- missing-folders-root-of-unzipped
- folders HOT 2
- startApp-fails
- redis-error HOT 2
- show-user-friendly-invalid-login-message-and-seed-with-admin-user HOT 4
- what-is-this-email-body-in-the-gui? HOT 6
- sendemail-false-does-nothing
- date-fields-binding-does-not-work
- html-permalink-unexpected-small-defect
- small-gui-fix
- textarea-paragraphs-not-honored-while-binding
- message-history-issues
- email-issues HOT 1
- email-issues-2
- generatedoc-false-email-text-html-control-should-auto-increase-height
- document.authrequired is not honoured
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from the-app.