Coder Social home page Coder Social logo

unless_modules bug fix about cardinal HOT 4 CLOSED

unlessgames avatar unlessgames commented on May 6, 2024 1
unless_modules bug fix

from cardinal.

Comments (4)

unlessgames avatar unlessgames commented on May 6, 2024 1

@dromer it should be compatible with Rack 2.3 I just wasn't aware of the problem until now.

@falkTX thanks for the info, I created a pull request and added a slightly modified version of your explanation to the wiki below, hope it's alright!

https://github.com/DISTRHO/Cardinal/wiki/Publishing-plugin-updates

from cardinal.

dromer avatar dromer commented on May 6, 2024

We haven't updated to the latest Rack2 version yet, but thank you for the heads up.
You could just do a PR with your submodule updated (if that is all that is needed).

If compatible with the current version of Rack2 that we use then it should be relatively easy to get it in.

from cardinal.

falkTX avatar falkTX commented on May 6, 2024

a document to explain how to update submodules is well overdue, but let me try to summarize the steps:

  1. create a cardinal fork through github
  2. clone that fork with --recursive (or change git remote to that new fork if you have already cloned cardinal before, can be done using)
git remote remove origin
git remote add origin [email protected]:YOUR_FORKED_ACCOUNT/Cardinal.git
  1. make sure all cardinal code and submodules are updated, to reduce risks of merge conflicts (can be done using)
git pull
git submodule update --init --recursive
  1. create a new branch within the Cardinal project for preparing the plugin module update (git checkout -b update-unless or similar)
  2. go into your plugin module folder and update it (like this)
cd plugins/unless_modules
git checkout main
git pull`

Note that the active commit on that module folder is going to be the one used by cardinal at the end.

  1. ping us if any new modules were introduced, so we can not only add it but also check for function/symbol name conflicts with other modules (this last step is automated).
    PS: it shouldn't be on single module devs to ensure global compat with other modules, as official Rack does not care, it is Cardinal's job here to ensure they all work together nicely

  2. go back to the main/root Cardinal folder, commit your changes and push then to the branch

  3. open a pull request against the official Cardinal github project

from cardinal.

dromer avatar dromer commented on May 6, 2024

Since this is merged we can close the issue.

from cardinal.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.