Comments (4)
@dromer it should be compatible with Rack 2.3 I just wasn't aware of the problem until now.
@falkTX thanks for the info, I created a pull request and added a slightly modified version of your explanation to the wiki below, hope it's alright!
https://github.com/DISTRHO/Cardinal/wiki/Publishing-plugin-updates
from cardinal.
We haven't updated to the latest Rack2 version yet, but thank you for the heads up.
You could just do a PR with your submodule updated (if that is all that is needed).
If compatible with the current version of Rack2 that we use then it should be relatively easy to get it in.
from cardinal.
a document to explain how to update submodules is well overdue, but let me try to summarize the steps:
- create a cardinal fork through github
- clone that fork with
--recursive
(or change git remote to that new fork if you have already cloned cardinal before, can be done using)
git remote remove origin
git remote add origin [email protected]:YOUR_FORKED_ACCOUNT/Cardinal.git
- make sure all cardinal code and submodules are updated, to reduce risks of merge conflicts (can be done using)
git pull
git submodule update --init --recursive
- create a new branch within the Cardinal project for preparing the plugin module update (
git checkout -b update-unless
or similar) - go into your plugin module folder and update it (like this)
cd plugins/unless_modules
git checkout main
git pull`
Note that the active commit on that module folder is going to be the one used by cardinal at the end.
-
ping us if any new modules were introduced, so we can not only add it but also check for function/symbol name conflicts with other modules (this last step is automated).
PS: it shouldn't be on single module devs to ensure global compat with other modules, as official Rack does not care, it is Cardinal's job here to ensure they all work together nicely -
go back to the main/root Cardinal folder, commit your changes and push then to the branch
-
open a pull request against the official Cardinal github project
from cardinal.
Since this is merged we can close the issue.
from cardinal.
Related Issues (20)
- [FEATURE REQUEST] Multichanel Host Audio HOT 12
- Pressing F9 in Cardinal crashes FL Studio instantly HOT 3
- Copy-pasting modules doesn't seem to work anymore HOT 10
- Low mouse wheel sensitivity HOT 2
- fixing unless_modules repo HOT 2
- Versioning of the Apps and Install Package. HOT 6
- Evaluate removal of malloc_usable_size for FORTIFY_SOURCE=3 HOT 2
- [FEATURE REQUEST] Adjust theme of background and modules independently HOT 2
- CLAP: Segmentation fault (core dumped) whilst attempting to load the plugin HOT 4
- X scroll - if it's not broken, don't fix it HOT 5
- System directory doesn't exist. Linux. HOT 18
- favourites not saving in presets any more HOT 9
- Cardinal VST3 not showing after update to 23.09 and old DAW projects crashing looking for it
- v23.09 LV2 Windows Creates Files Everywhere, Or Maybe in the Current Working Directory HOT 16
- Cannot find Carla on Linux
- STROKE Zoom toggle seems to be broken on nightly build HOT 4
- Logic woes HOT 4
- Ableton Live 11.3 - Monitoring Stops while editing any parameter HOT 9
- Is there an easy way to filter which modules are included in the build? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cardinal.