Coder Social home page Coder Social logo

Comments (8)

Dirvann avatar Dirvann commented on July 3, 2024

Hi thanks for the improvement tip. I do think there is still a need to close the audio and video stream after getUsermedia otherwise it would keep them in use. Or is this not the case when you tested it?

from mediasoup-sfu-webrtc-video-rooms.

miroslavpejic85 avatar miroslavpejic85 commented on July 3, 2024

Yeah you right... :) you can close the audio-video stream after getUsermedia...

from mediasoup-sfu-webrtc-video-rooms.

Dirvann avatar Dirvann commented on July 3, 2024

Alright, I'll make the changes soon, unless you have a PR request ready, thanks!

from mediasoup-sfu-webrtc-video-rooms.

miroslavpejic85 avatar miroslavpejic85 commented on July 3, 2024

Just add this

    .then((stream) => {
        enumerateDevices();
        stream.getTracks().forEach(function(track) {
            track.stop();
        });
    })

from mediasoup-sfu-webrtc-video-rooms.

miroslavpejic85 avatar miroslavpejic85 commented on July 3, 2024

Alright, I'll make the changes soon, unless you have a PR request ready, thanks!

As you prefer, I can also get you a PR if you want? My pleasure to help ;)

from mediasoup-sfu-webrtc-video-rooms.

Dirvann avatar Dirvann commented on July 3, 2024

That would be awesome!

from mediasoup-sfu-webrtc-video-rooms.

miroslavpejic85 avatar miroslavpejic85 commented on July 3, 2024

@Dirvann I sent you a PR.

from mediasoup-sfu-webrtc-video-rooms.

Dirvann avatar Dirvann commented on July 3, 2024

solved in #13

from mediasoup-sfu-webrtc-video-rooms.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.