Comments (5)
master...stormyqq:patch-1
It's fixed.
from newpoints.
Thanks :)
from newpoints.
Duplicate of #8 .
I can't accept your Pull Request because it modifies parts which are not required (only the preg_replace call which uses the e modified needs to be changed) and because your modification to the first call of preg_replace doesn't do what it's supposed to.
It's supposed to remove the quote tags, not to keep the quote tag that matches the first pattern, as your fix does. The code was originally part of http://forums.mybb-plugins.com/Thread-OUGC-Post-Character-Count-Enhancement but I failed to notice the e modified.
To my knowledge, simply removing it fixes the issue, because we don't need to evaluate any code within it. We just want to strip everything that matches the first pattern.
from newpoints.
Yes, your code made it compatible but wouldn't work as expected. It would give no warnings but the code wouldn't remove the quote tags properly. I've fixed it by simply removing the 'e' modified, which is deprecated and we don't need to eval anything so we don't need to use the _callback function.
Anyway, thanks for putting your time into this.
from newpoints.
I think you're not understanding. The callback function may be recommended but your solution would replace the match with the content of $match[0] which doesn't make sense because we want to strip the quote tag and its contents. Basically, your PR doesn't fix the issue, it fixes the warning.
from newpoints.
Related Issues (14)
- Template is still active if user is deleted HOT 2
- Error on /inc/plugins/newpoints/core/hooks.php on line 446 HOT 1
- Displaying NewPoints in Preview Post window HOT 1
- Blank Screen in Admin CP HOT 4
- Finding Users Points. HOT 1
- Regex 'e' modifier
- Recount - Ignores Spent Points HOT 1
- Cant Donate HOT 1
- Upgrade does not work Error 500 HOT 4
- Doesn't work with PostgreSQL
- How to show point of users.?
- Max donation limit not working as expected
- more VÄ°P membership
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
đ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. đđđ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google â¤ď¸ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from newpoints.