Comments (5)
The exact behavior of this method should be checking for owning status and delete the element if necessary. If T is not a pointer, it is not necessary. But for the Vector case, what I was thinking is that if I can pass a pointer to the container, then I at least have a reference of the object and if I want to remove it from the container then I may not want to invalidate my reference at the same time. So the behavior here is not standard but it is reasonable. I don't know how to reconcile this obvious conflict. Do you have any idea?
from mql4-lib.
If Collection
class has public m_owned
flag then we have to support it in every inherited implementation. Thus, if m_owned
is set, Vector
implementation MUST destroy the element which is thrown out of it. Otherwise, there's no point in having m_owned
flag in the first place. So must do every other derived class. So I don't think I get your point here ๐
Globally, I think that the library must have consistent, non-contradictory API throughout all the code base. Ideally, all these caveats must be documented, or at least (which is more important) all derived classes must display the same behaviour hinted by their ancestors.
from mql4-lib.
OK, I think you are right. I will fix the inconsistency ASAP.
from mql4-lib.
Hi, any success? I'd be glad if you process the PR backlog out there ๐
from mql4-lib.
Not yet. Sorry for the slow response to your PR. I am extremely busy since I changed my job... I will try to process your PRs tonight. Thanks for your contribution.
from mql4-lib.
Related Issues (20)
- Save and load Vector from disk HOT 3
- New update to MT4 1210 2019.9.6, LinkedList.mqh ERROR. HOT 2
- ArrayList is mentioned in the documentation, however it's missing in the code
- Pushing to Vector or Linked list a reference cause compiler error HOT 2
- Implement "as series" for Vector
- Array out of range error while iterating over elements in the Vector HOT 1
- how to sort the LinkedList HOT 1
- "Invalid Point access" error on calling SymbolAnalyzer::getConversionSymbol of FxSymbol module HOT 1
- '=' - type mismatch GlobalVariable.mqh HOT 3
- '=' - type mismatch GlobalVariable.mqh 292 12 HOT 1
- Please update Json parse example in README file
- Json.mqh ็ parseInt ๆฏๅฆ่ฉฒๅไปฅไธไฟฎๆญฃ? HOT 3
- Finish Making Cross Version HOT 1
- 1
- Compilation error in 'HelloWorldServer.mq4' file HOT 2
- Can i use this libary for trade a account without EA HOT 4
- Classes in collections HOT 1
- does this lib support mac os m1 HOT 2
- LinkedList Initialization in MQL4 HOT 3
- SortedArray with custom SortComparer HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mql4-lib.