Comments (4)
Hey SirMuppit.
Sorry for the really late reply. The check is there to ensure that we're not loading images that are hidden. When the offset values are 0 they're either hidden (display:none) or collapsed.
Do you have a live example I can see?
from blazy.
Hey
Ye, so i have patched it with my suggested fix and it seems to work well now. You can see a live example here: http://s.boardmans.fontera.com/shop-by-room/kitchen/category/storage/show/all.html
I have implemented your script into a working Magento Module that could be reused on other Magento sites.
Regards
Shaughn
On 23 Jul 2014, at 12:50 PM, dinbror [email protected] wrote:
Hey SirMuppit.
Sorry for the really late reply. The check is there to ensure that we're not loading images that are hidden. When the offset values are 0 they're either hidden (display:none) or collapsed.
Do you have a live example I can see?
—
Reply to this email directly or view it on GitHub.
from blazy.
Hey,
because you removed the check all your images are getting both the error and success class added: "b-error b-loaded".
How do you load the images with ajax?
from blazy.
Hey, I’m not sure to be exact, i will need to setup a vanilla Magento store and check each instance. For now, close the bug and ill give more feedback and details on it as soon as i have a chance, since i can’t remember any of my finding’s lol.
I did notice the duplicate classes being added, but i will need to do a diff from you current version with the version i have now and see whats different.
Thanks for the reply, though. Much appreciated.
Regards
Shaughn
On 05 Aug 2014, at 2:41 PM, dinbror [email protected] wrote:
Hey,
because you removed the check all your images are getting both the error and success class added: "b-error b-loaded".
How do you load the images with ajax?
—
Reply to this email directly or view it on GitHub.
from blazy.
Related Issues (20)
- srcset bug in Chrome & FF
- Not working on hidden tabs HOT 1
- Make bLazy available via composer? HOT 2
- Not working with webpack Encore HOT 1
- Issue in Safari & Firefox (page stays blank for 5-7 seconds)
- Parsing data-src with URL parameters HOT 2
- Background images data-src-small HOT 1
- Not working on Android 'data-src'
- Is an 'alt' attribute required in img tags? HOT 1
- What is the meaning of "loadInvisible"? HOT 3
- Current project status HOT 2
- not working in silder HOT 2
- Not working with older IE browsers versions 5 & 7 HOT 2
- Is it possible to use JS to alter src to data-src on iframe? HOT 2
- invalid issues
- Video and poster
- Cannot exclude featured image HOT 2
- Default lazyload image example Not working
- Safari iOS 15.4.1 lazy loading not working. HOT 2
- Doesn't work with pagination
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from blazy.