Coder Social home page Coder Social logo

Comments (4)

dinbror avatar dinbror commented on July 17, 2024

Hey SirMuppit.

Sorry for the really late reply. The check is there to ensure that we're not loading images that are hidden. When the offset values are 0 they're either hidden (display:none) or collapsed.

Do you have a live example I can see?

from blazy.

shaughnlgh avatar shaughnlgh commented on July 17, 2024

Hey

Ye, so i have patched it with my suggested fix and it seems to work well now. You can see a live example here: http://s.boardmans.fontera.com/shop-by-room/kitchen/category/storage/show/all.html

I have implemented your script into a working Magento Module that could be reused on other Magento sites.

Regards
Shaughn

On 23 Jul 2014, at 12:50 PM, dinbror [email protected] wrote:

Hey SirMuppit.

Sorry for the really late reply. The check is there to ensure that we're not loading images that are hidden. When the offset values are 0 they're either hidden (display:none) or collapsed.

Do you have a live example I can see?


Reply to this email directly or view it on GitHub.

from blazy.

dinbror avatar dinbror commented on July 17, 2024

Hey,

because you removed the check all your images are getting both the error and success class added: "b-error b-loaded".

How do you load the images with ajax?

from blazy.

shaughnlgh avatar shaughnlgh commented on July 17, 2024

Hey, I’m not sure to be exact, i will need to setup a vanilla Magento store and check each instance. For now, close the bug and ill give more feedback and details on it as soon as i have a chance, since i can’t remember any of my finding’s lol.

I did notice the duplicate classes being added, but i will need to do a diff from you current version with the version i have now and see whats different.

Thanks for the reply, though. Much appreciated.

Regards
Shaughn

On 05 Aug 2014, at 2:41 PM, dinbror [email protected] wrote:

Hey,

because you removed the check all your images are getting both the error and success class added: "b-error b-loaded".

How do you load the images with ajax?


Reply to this email directly or view it on GitHub.

from blazy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.