Coder Social home page Coder Social logo

Comments (11)

dabele91 avatar dabele91 commented on July 4, 2024 2

Same problem here. Would be nice if someone has an idea how to resolve this issue.

from androidpdfviewer.

paperrose avatar paperrose commented on July 4, 2024 2

@dabele91

public class PDFViewPager extends ViewPager {

    public PDFViewPager(Context context) {
        super(context);

    }

    public PDFViewPager(Context context, AttributeSet attrs) {
        super(context, attrs);
    }

    @Override
    protected boolean canScroll(View v, boolean checkV, int dx, int x, int y) {
        if (v instanceof ViewGroup) {
            final ViewGroup group = (ViewGroup) v;
            final int scrollX = v.getScrollX();
            final int scrollY = v.getScrollY();
            final int count = group.getChildCount();
            for (int i = count - 1; i >= 0; i--) {
                final View child = group.getChildAt(i);
                if (x + scrollX >= child.getLeft() && x + scrollX < child.getRight() &&
                        y + scrollY >= child.getTop() && y + scrollY < child.getBottom()) {
                    if ((child instanceof PDFView && isNotHorizontalBounds((PDFView)child, dx)) || canScroll(child, true, dx, x + scrollX - child.getLeft(),
                            y + scrollY - child.getTop()))
                        return true;
                }
            }
        }

        return checkV && false;
    }

    private boolean isNotHorizontalBounds(PDFView view, int dx) {
        final float zoom = view.getZoom();
        final float pageWidth = view.getWidth()*zoom;
        final float offset = view.getCurrentXOffset();
        if (offset + pageWidth <= getWidthScreen() + 1 && dx < 0) return false;
        if (offset >= -1 && dx > 0) return false;
        return true;
    }

    private int getWidthScreen(){
        WindowManager wm = (WindowManager) getContext().getSystemService(Context.WINDOW_SERVICE);
        Display display = wm.getDefaultDisplay();
        Point size = new Point();
        display.getSize(size);
        return size.x;
    }
} 

from androidpdfviewer.

MoQ93 avatar MoQ93 commented on July 4, 2024 1

That's because canScrollHorizontally(int direction) is not implemented, which is already requested in issue #19

from androidpdfviewer.

peshkira avatar peshkira commented on July 4, 2024 1

Hi @MonaHammad!

The ViewPager is part of the android support library: https://developer.android.com/reference/android/support/v4/view/ViewPager.html

It is not related to this PDF library. This issue here is relevant if you show multiple PDFs inside a view pager. Hope this helps.

best

from androidpdfviewer.

paperrose avatar paperrose commented on July 4, 2024

Had the same problem, but fixed it with overriding VP canScroll method

from androidpdfviewer.

dabele91 avatar dabele91 commented on July 4, 2024

@paperrose can you write an example how you've implemented the canScroll functionality?

from androidpdfviewer.

dabele91 avatar dabele91 commented on July 4, 2024

@paperrose works lke a charm. thanks ;-)

from androidpdfviewer.

hustyichi avatar hustyichi commented on July 4, 2024

Thank you , it works

from androidpdfviewer.

paperrose avatar paperrose commented on July 4, 2024

Just find a small bug in my code above. In landscape orientation right-to-left swipe doesn't change page
Solved by replacing
final float pageWidth = view.getWidth()*zoom;
to
final float pageWidth = view.getOptimalPageWidth()*zoom;

from androidpdfviewer.

MonaHammad avatar MonaHammad commented on July 4, 2024

How to use this approach, I can't find ViewPager class?

from androidpdfviewer.

MonaHammad avatar MonaHammad commented on July 4, 2024

Hi @peshkira
Ok, thanks.
But how to use it here to improve the paging while zooming in this library?
I couldn't figure out how to use PDFViewPager?

from androidpdfviewer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.