Can not use package like xxx.model.yyy.model.ZzzModel about slim3

[GoogleCodeExporter]

Original comment by [email protected] on 18 Jun 2010 at 10:10

• Changed state: Accepted
• Added labels: Version-1.0.5
• Removed labels: Version

[GoogleCodeExporter]

Original comment by [email protected] on 18 Jun 2010 at 11:37

• Changed state: Fixed

[GoogleCodeExporter]

The Rev#r1292 seems to have DatastoreUtil#replacePackageName and 
ModelMetaClassName#replacePackageName both replace the FIRST occurrence of 
".model." with ".meta.". The meta of xxx.model.yyy.model.ZzzModel will be 
xxx.meta.yyy.model.ZzzModel. Am I right? Is there any special design 
consideration? 

Isn't it more intuitive that the meta of xxx.model.yyy.model.ZzzModel becomes 
xxx.model.yyy.meta.ZzzModelMeta ?

Original comment by [email protected] on 18 Jun 2010 at 1:23

[GoogleCodeExporter]

Correct a mistake in the previous comment.

> The meta of xxx.model.yyy.model.ZzzModel will be xxx.meta.yyy.model.ZzzModel
The meta of xxx.model.yyy.model.ZzzModel will be xxx.meta.yyy.model.ZzzModelMeta

Original comment by [email protected] on 18 Jun 2010 at 1:32

[GoogleCodeExporter]

> The meta of xxx.model.yyy.model.ZzzModel will be 
xxx.meta.yyy.model.ZzzModelMeta.
> Am I right?

Yes you are.

> Is there any special design consideration?

It's just rule, no special design consideration.

> Isn't it more intuitive that the meta of xxx.model.yyy.model.ZzzModel becomes
> xxx.model.yyy.meta.ZzzModelMeta ?

What kind of rule do you recommend?

Original comment by [email protected] on 18 Jun 2010 at 10:49

[GoogleCodeExporter]

Some of the names of packages in our project are <project.root>.controller, 
<project.root>.dao, <project.root>.dao.impl, <project.root>.model, etc.

We put the corresponding slim3 implementation classes into the slim3 
subpackages listed below.

<project.root>.controller.slim3
<project.root>.dao.impl.slim3
<project.root>.model.slim3

If some other framework (for example, twig) is used, the subpackage names will 
be changed (from slim3 to twig) accordingly. 

The original slim3gen convention demands that we put model classes into 
<project.root>.model.slim3.model subpackage and the generated meta classes in 
<project.root>.model.slim3.meta. The original slim3gen rule and  and our 
package hierarchy are very intuitive.

The Rev#r1292 fix will put the meta classes into 
<project.root>.meta.slim3.model subpackage. The behavior will break the package 
hierarchy because <project.root>.meta package is for slim3 only and the 
'.slim3.model' postfix becomes redundant and unnatural now.

My opinion is that the original slim3gen rule which replace the LAST occurrence 
of '.model.' with '.meta.' is better at least in our case.

Thank you for quick fix and responses to this issue.

Original comment by [email protected] on 18 Jun 2010 at 11:42

[GoogleCodeExporter]

Your request is reasonable.
I fixed it.

Original comment by [email protected] on 19 Jun 2010 at 2:01

[GoogleCodeExporter]

Thank you very much! I will compile the slim3.jar from the current slim3 trunk 
source code and use it till the official 1.0.5 is released. 

Original comment by [email protected] on 19 Jun 2010 at 3:04