Comments (3)
Ya, the API is lenient enough that it will attempt to parse the string as an integer. We shouldn't rely on that and instead correctly marshal CreateDropletRequest.Image
as an int/string as required.
from godo.
Frankly, I think this is more of a "no-no" on the API side. If the API is lenient enough to support numbers as strings, for private images, why not just enforce the type on the API, to always be a string?
from godo.
I agree it would be best to make the API less lenient but I also think it may be a bit too late for that as other clients may not exhibit this same behavior and may correctly pass an int or a string.
Either way it would be best to change the client to correctly follow the documented behavior of:
number (if using an image ID), or String (if using a public image slug)
Then if the behavior changes, we can correct the client as well.
from godo.
Related Issues (20)
- Enhancement request: Enhance Droplet Create API to also take project id HOT 5
- Add to fetch details of monitoring alert policies. HOT 1
- Add project information in response of list and get call of all resources. HOT 1
- Support for TTL in domain create
- Floating IP deleting only on second time HOT 3
- CVE-2021-27918 (High) detected in github.com/golang/net-e086a090c8fdb9982880f0fb6e3db47af1856533 HOT 1
- CVE-2021-31525 (Medium) detected in github.com/golang/net-e086a090c8fdb9982880f0fb6e3db47af1856533 HOT 1
- CVE-2021-33194 (High) detected in github.com/golang/net-e086a090c8fdb9982880f0fb6e3db47af1856533
- Account
- Create Snapshot Missing HOT 2
- [Feature Request] Add specifying image by name support to DropletCreateImage
- Kubernetes `surge_upgrade` field cannot be set to `false` HOT 3
- https://github.com/notxarb/openapi/tree/main
- App
- CVE-2022-27664 (High) detected in github.com/golang/net-290c469a71a567d354e4abd335577aba44c4bde4
- CVE-2022-41721 (High) detected in golang.org/x/net-v0.0.0-20220921155015-db77216a4ee9 HOT 1
- How to get error message HOT 1
- Typo in the Readme # Build Status is not showing an icon HOT 5
- Code of conduct was missing. I added it HOT 2
- move doctl config into this library? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from godo.