StorageActions.Detach should accept a droplet_id about godo

[bryanl]

Hello,

Thanks for pointing this out. We'll take a look at this in the near future.

[aybabtme]

@omallo are you sure the volume ID you attempted to use existed? The docs are erroneously stating that a droplet ID is required, when in fact the argument is optional.

[omallo]

@aybabtme I just tested it with the following curl commands and I'm getting an error if I don't pass the droplet_id to the detach action (if I pass it, everything works fine):

export DO_API_TOKEN=...

curl -sS -X POST -H "Content-Type: application/json" -H "Authorization: Bearer $DO_API_TOKEN" -d '{"size_gigabytes":1, "name": "example", "region": "fra1"}' "https://api.digitalocean.com/v2/volumes"
{
    "volume": {
        ...
        "id": "21f922a5-95da-11e6-9c0d-000f53304720",
        ...
    }
}

curl -sS -X POST -H "Content-Type: application/json" -H "Authorization: Bearer $DO_API_TOKEN" -d '{"type": "attach", "droplet_id": "29577663", "region": "fra1"}' "https://api.digitalocean.com/v2/volumes/21f922a5-95da-11e6-9c0d-000f53304720/actions"
{
    ...
}

curl -sS -X POST -H "Content-Type: application/json" -H "Authorization: Bearer $DO_API_TOKEN" -d '{"type": "detach", "volume_name": "example", "region": "fra1"}' "https://api.digitalocean.com/v2/volumes/actions"
{
    "id": "parameter_missing",
    "message": "param is missing or the value is empty: droplet_id"
}

[mjsteger]

@omallo The problem there is that there is a bug in the API, where it requires either the volume_id or the droplet_id to be passed in. I'll fix that so that if either the volume_id or volume_name is passed it, it'll deduce the droplet from that.

[wardviaene]

@mjsteger

I have the same issue with godo, but getting different results (still not working though):

This is how it is implemented right now in godo:

curl -sS -X POST -H "Content-Type: application/json" -d '{"type": "detach", "region": "fra1"}' -H "Authorization: Bearer $DO_API_TOKEN" https://api.digitalocean.com/v2/volumes/$VOLUMEID/actions

Which gives me:
{"id":"invalid","message":"Attachment not found"}

After adding droplet_id as argument it works.

[wardviaene]

@bryanl @aybabtme Can the godo API at least get changed with an extra method that catches the droplet_id, as described in the docs? If DigitalOcean one day decides to have multiple droplets attached to one volume, then this API call will have bad consequences.

[bryanl]

@aybabtme care to follow up again? It looks like @wardviaene is trying to whip up some Kubernetes support.