Incorrect processing of lists about pyld

[dlongley]

Would changing the frame to the following solve your problem?

{
    "@context" : "http://www.shared-canvas.org/ns/context.json",
    "@type": "sc:Manifest",
    "structures": [
        {
            "@type":"sc:Range",
            "@embed": true,
            "canvases": [
                {
                    "@embed":false
                }
            ]
        }
    ]
}

I didn't look too closely, but it looked incorrect/unnecessarry to be using "@list" in a frame. You also can't "filter" lists -- it changes the data, not just its structure.

[azaroth42]

No, I tried that. The issue is that the object of the canvases predicate
is an rdf:List, which has members that should not be embedded.

I'll build a test case.

Rob

On Thu, Aug 1, 2013 at 8:34 PM, Dave Longley [email protected]:

Would changing the frame to the following solve your problem?

{
"@context" : "http://www.shared-canvas.org/ns/context.json",
"@type": "sc:Manifest",
"structures": [
{
"@type":"sc:Range",
"@embed": true,
"canvases": [
{
"@embed":false
}
]
}
]}

I didn't look too closely, but it looked incorrect/unnecessarry to be
using "@list https://github.com/list" in a frame.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/21#issuecomment-21983221
.

[azaroth42]

The frame, using the above style, is:
http://www.shared-canvas.org/ns/frame/manifest.json

An example instance is:
http://www.shared-canvas.org/ns/frame/metadata-eg.json

And the script I use:
http://www.shared-canvas.org/ns/frame/framer.py

When framing the instance, the Canvas objects get embedded into the "structures" block, and not in the "sequences" block even though the frame explicitly states otherwise.

Hope that helps, or at least illustrates the problem! :)

Rob

[dlongley]

@azaroth42, I don't have much time to look further into this issue at the moment, unfortunately, but your fix seems like it implements the correct behavior so I've added it. I've got to update list processing, in general, in pyld to comply with recent changes to the spec before I can confirm that there aren't other side effects as a result of this change.

[azaroth42]

Thanks Dave! Happy to help if there's anything else I can contribute.

[dlongley]

Everything has been updated to comply with the latest spec and test-suite, closing now.