UPS Labels have the word "Sample" across the bar code about omniship

[adamthedeveloper]

I think I am figuring out what is happening with your gem and SAMPLE being shown in the barcode if you pass in :test => false in the options. In a few places in your code you are doing

(options[:test] || true)

if I pass in :test => false, the above code will always evaluate to true. You can prove this if you open a console and do

false || true

So one of either two things is happening here, 1) you expect me to pass in something other than false or nil or 2) this is a bug and you need to check to see if options[:test].nil?

I think the later is what you want - since your default value is a boolean.

I'll fix this in my fork - let me know if you want a pull request - this is a pretty big issue for your gem.

[Digi-Cazter]

My apologies for the bug, I went ahead and fixed it, now if you want to run in test mode you can pass :test => true, else if you don't pass :test or it's set to false it will be in production. Thank you for the input.

[adamthedeveloper]

Great! Thanks and nice gem. It's doing exactly what we need.

[Digi-Cazter]

Awesome, thanks! If you find anything that could be done better, or something you would like implemented, post it. Also if you come up with some better documentation you would like added, feel free to do a pull request with your changes.