Coder Social home page Coder Social logo

bug with mft.reshape about mesh HOT 4 CLOSED

b-remy avatar b-remy commented on September 23, 2024
bug with mft.reshape

from mesh.

Comments (4)

EiffL avatar EiffL commented on September 23, 2024 1

Hey @b-remy, I opened a new branch based on a different version of horovod, and so far it looks like I'm not getting deadlocks.... but this different horovod impl needs a bit more testing.

Can you work on the transpose issues even with this bug and deadlocks happening? Or do we need to solve the deadlocks first?

from mesh.

EiffL avatar EiffL commented on September 23, 2024 1

so, @b-remy I think this solved itself for some reason when switching to max_vd, right? can we close it?

from mesh.

b-remy avatar b-remy commented on September 23, 2024

On a simpler example mtf.transpose also has an issue:

Comparing tf.transposeand mtf.transpose on a 4x1 mesh:
random-4-1v2

There is no deadlock for this one, but we can clearly see that the transpose is correct only on one slice of the cube.

The functions from hvd_simd_mesh_impl.py that mtf.transpose calls are: allconcat and slicewise and slice.

from mesh.

b-remy avatar b-remy commented on September 23, 2024

Yes we can close it :)
It was indeed solved when using the new version of horovod and switching to the max_hvd branch.

from mesh.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.