Videos supported by avc hardware decoder(?) doesn't work in Android O about android_hardware_sprd

[diepquynh]

Camera recording never work on O with prebuilt HAL. The reason was we need to switch to native handle implementation rather than getting buffers from gralloc HAL

[enriquezmark36]

How about playing a video, it seems that it also uses gralloc to fetch buffers, doesn't it?

[diepquynh]

Playing videos is ok. 1080p30 is fine

[diepquynh]

Other resolutions too

[enriquezmark36]

TL;DR; It's okay now. I can now play videos up to 1080p30. So, I'll be closing this. :)

It seems that a patch libstagefright: Make it possible to skip OMX buffer reallocation didn't make it to LineageOS 15. Though this made me ask:
What does BOARD_CANT_REALLOCATE_OMX_BUFFERS := true in scx35-common/BoardConfigCommon.mk even do?

Unfortunately, it doesn't fix the camera recording. It hangs after the 00:01 time. AFAIK, LineageOS devs are working on the "legacy" HAL1 camera recording issue.

Anyways, here's the patch I used on frameworks/av that just tests this idea.

diff --git a/media/libstagefright/ACodec.cpp b/media/libstagefright/ACodec.cpp
index def8ada3c..47d622bfa 100644
--- a/media/libstagefright/ACodec.cpp
+++ b/media/libstagefright/ACodec.cpp
@@ -1182,6 +1182,12 @@ status_t ACodec::configureOutputBuffersFromNativeWindow(
     // 2. try to allocate two (2) additional buffers to reduce starvation from
     //    the consumer
     //    plus an extra buffer to account for incorrect minUndequeuedBufs
+#if 1
+    // Some devices don't like to set OMX_IndexParamPortDefinition at this
+    // point (even with an unmodified def), so skip it if possible.
+    // This check was present in KitKat.
+    if (def.nBufferCountActual < def.nBufferCountMin + *minUndequeuedBuffers) {
+#endif
     for (OMX_U32 extraBuffers = 2 + 1; /* condition inside loop */; extraBuffers--) {
         OMX_U32 newBufferCount =
             def.nBufferCountMin + *minUndequeuedBuffers + extraBuffers;
@@ -1201,7 +1207,9 @@ status_t ACodec::configureOutputBuffersFromNativeWindow(
             return err;
         }
     }
-
+#if 1
+    }
+#endif

[diepquynh]

The flag is removed in LOS 15.1
However, you can bring it back via patching method

[enriquezmark36]

Oh, that's why. Does the camera recording work by now for HAL1? I don't think I have done much researches.

[diepquynh]

It will never work with prebuilt camera blobs, because O won't use gralloc source for camera, instead using native handle struct for it