[Bug] Recovering Wallet queries validator for no reason raising 429 errors about diem

[xfyfb]

During wallet recovery, client will try to sync with validator for the latest sequence number. As the client/wallet generates address deterministically, if the same mnemonic file is used, the account might already exists on chain. In this case, cli/wallet will need the latest sequence number to submit transaction. 429 is from rate limit and is supposed to be transient, and it should work with retry.

[xfyfb]

Oh, I saw you set the child number to 500. It will recover 500 accounts and issue 500 rpc calls to validator, which is over the limit. Please try with a small number first and we will fix it with a more flexible solution.

[kf106]

Glad you noticed that. A suggestion: the sequence number sync should only occur when a transaction that relies on a valid sequence number is issued. So on generating e.g. 500 addresses, they could all start with sequence number -1, and then when an address is queried for balance or a transaction is issued, first submit a sync rpc.

[icarter09]

@kf106 are you still experiencing this issue?

[xfyfb]

@kf106, the changes already merged. Can you run again and verify?

[kf106]

On it now.

[kf106]

Verified as improved.