Comments (4)
Hi @dgreene1, feel free to open a PR that rewrites the library in TypeScript. I'm open to PRs for fixes/improvements, although I'm not currently interested in further development of the library on my own time.
from react-accessible-treeview.
Thank you for the info @lissitz. Just in case our company (who is doing major accessibility work) agrees to allocating people’s time, I want to check to see if you’d be willing to accept me being added as a maintainer so I can assist/control the publishing/releases so that a11y and security patches can be released in a timely manner?
You could keep the library in your namespace/org since that’s a pain. This would be just an offer to have a 2nd maintainer who might have budget during work hours (still waiting to hear back from our engineering budget people at the company).
from react-accessible-treeview.
Yes, I'm open to eventually adding you as a maintainer 🙂.
from react-accessible-treeview.
@lissitz our company has allocated funding for us to do the rewrite in the next couple of weeks. We have a question though: Do you want to preserve the runtime validation that prop-types was accomplishing? Or is the compile time validation of TypeScript enough?
It’s possible to have both, but removing runtime validation would decrease the bundle size and would remove the runtime lag that comes with checking the input.
If you say “both please” we will be using either https://github.com/gcanti/prop-types-ts or https://github.com/colinhacks/zod. I prefer zod since it has a smaller footprint than prop-types-ts. But my preference would be to use Typescript alone without any runtime validation.
from react-accessible-treeview.
Related Issues (20)
- ScrollTo functionality HOT 4
- onNodeSelect is not invoked when selection is from selected -> halfSelected HOT 4
- flattenTree function doesn't persist isBranch property HOT 11
- Half-selected state only set for parent HOT 1
- Expanding/collapsing child deselects parent when propagateSelect is false HOT 1
- Give NPM publishing permissions to me and/or deprecate this library HOT 11
- Cannot Keyboard focus into TreeView Component HOT 17
- Selected Tree Item on Focus - no selected item behaviour HOT 3
- Remove onBlur from examples HOT 1
- Add custom properties to element object HOT 3
- Pass additional data to nodes HOT 4
- Do not publish src/index.ts to npm HOT 3
- Chose whether we want `focus` or `scrollIntoView` when changing expandedIds HOT 9
- New release? HOT 6
- Additional data in flattenTree & Node HOT 1
- Type INode should have an additional property to store meta data. HOT 5
- String support for data id HOT 2
- Remove ability to disable selection propagation HOT 6
- Disable all children of disabled node HOT 6
- Question: Select any node through function call HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-accessible-treeview.