Coder Social home page Coder Social logo

Comments (4)

lissitz avatar lissitz commented on May 19, 2024

Hi @dgreene1, feel free to open a PR that rewrites the library in TypeScript. I'm open to PRs for fixes/improvements, although I'm not currently interested in further development of the library on my own time.

from react-accessible-treeview.

dgreene1 avatar dgreene1 commented on May 19, 2024

Thank you for the info @lissitz. Just in case our company (who is doing major accessibility work) agrees to allocating people’s time, I want to check to see if you’d be willing to accept me being added as a maintainer so I can assist/control the publishing/releases so that a11y and security patches can be released in a timely manner?

You could keep the library in your namespace/org since that’s a pain. This would be just an offer to have a 2nd maintainer who might have budget during work hours (still waiting to hear back from our engineering budget people at the company).

from react-accessible-treeview.

lissitz avatar lissitz commented on May 19, 2024

Yes, I'm open to eventually adding you as a maintainer 🙂.

from react-accessible-treeview.

dgreene1 avatar dgreene1 commented on May 19, 2024

@lissitz our company has allocated funding for us to do the rewrite in the next couple of weeks. We have a question though: Do you want to preserve the runtime validation that prop-types was accomplishing? Or is the compile time validation of TypeScript enough?

It’s possible to have both, but removing runtime validation would decrease the bundle size and would remove the runtime lag that comes with checking the input.

If you say “both please” we will be using either https://github.com/gcanti/prop-types-ts or https://github.com/colinhacks/zod. I prefer zod since it has a smaller footprint than prop-types-ts. But my preference would be to use Typescript alone without any runtime validation.

from react-accessible-treeview.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.