Coder Social home page Coder Social logo

default for s9 in dftd3 about simple-dftd3 HOT 2 CLOSED

dftd3 avatar dftd3 commented on June 28, 2024
default for s9 in dftd3

from simple-dftd3.

Comments (2)

awvwgk avatar awvwgk commented on June 28, 2024

You are right this is inconsistent. Most of the code base use s9=1.0 by default, while the parameters.toml uses s9=0.0, which creates the inconsistency in get_all_damping_params. Leaving the ATM on by default seems like the safer choice in my opinion.

from simple-dftd3.

loriab avatar loriab commented on June 28, 2024

Thanks. For now, locally, I'll update the s9=0.0 -> 1.0 at the parameter acrobatics step in qcengine, https://github.com/MolSSI/QCEngine/blob/master/qcengine/programs/empirical_dispersion_resources.py#L902 , so that reported parameters match used ones. ("classic" dftd3 can ignore s9.) Then perhaps later parameters.toml upstream can change for single-source-of-truth?

from simple-dftd3.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.