Coder Social home page Coder Social logo

Comments (2)

vijaymarupudi avatar vijaymarupudi commented on September 22, 2024 1

Appreciate you taking a look at this!

Looks like many Befaco modules don't follow the voltage standards, for example, Rampage doesn't.

https://github.com/VCVRack/Befaco/blob/1698b616dd284db3d7e1eb0d2a54f3931a4772db/src/Rampage.cpp#L223

Would appreciate a change in behavior, I'll send a pull request to Befaco to fix this in the modules I can find, but I suspect many other modules don't implement this properly in practice...

from monome-rack.

Dewb avatar Dewb commented on September 22, 2024

Hi, thanks for the report! I believe the core issue here is with Befaco Kickall; the Rack Voltage Standards specify that dropping below 0.1V should be enough to clear a trigger input: https://vcvrack.com/manual/VoltageStandards#Triggers-and-Gates

Kickall should use the three-argument version of SchmittTrigger::process() here, to specify a 0.1V low and 1V high threshold. (The defaults are 0.0 and 1.0): https://github.com/VCVRack/Befaco/blob/1698b616dd284db3d7e1eb0d2a54f3931a4772db/src/Kickall.cpp#L84

The slight offset (it's less than 0.001V, but Rack rounds up) on the DAC outputs is intentional to reduce the average absolute pitch error, but it is confusing in circumstances like this when the DAC outs are used as triggers, so I'm going to look at changing that behavior in the next release.

from monome-rack.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.