Incorrect version given to doczip with devpi-client version 7.0.0 about devpi

[fschulze]

Does this happen with both devpi-client 6.x and 7.x?

With the current version, could you try isolated=not self.args.no_isolation. That seems to be the most sensible fix.

As an optimization, we could look into getting the metadata from previously built artifacts like wheels and pass that on to the documentation building step.

[eachimei]

Does this happen with both devpi-client 6.x and 7.x?

No, it started happening only with 7.0.0 due to the switch from pep517 to build. As I will show below, the switch changed important functionality aspects.

As can be seen, the relevant commit included in 7.0.0:
8bd048d#diff-654fa2126392edd2daaa3b4f621ad8805e93d9ab5096727fd704dcbd222ce54fL394

The "old" code was:

    def setup_name_and_version(self):
        result = pep517.meta.load(self.rootpath.strpath)

And if we track down pep517.meta.load() we can see the it winds up to:
https://github.com/pypa/pyproject-hooks/blob/v0.13.0/pep517/meta.py#L53

# eachimei: `pep517.meta.load` runs this:
def build(source_dir='.', dest=None, system=None):
    system = system or load_system(source_dir)
    dest = os.path.join(source_dir, dest or 'dist')
    os.makedirs(dest, exist_ok=True)
    validate_system(system)
    hooks = Pep517HookCaller(
        source_dir, system['build-backend'], system.get('backend-path')
    )

    with hooks.subprocess_runner(quiet_subprocess_runner):
        with BuildEnvironment() as env:                # <--- eachimei: isolated environment
            env.pip_install(system['requires'])        # <--- eachimei: install the build system requirements

Therefore, it seems that for "apples to apples" switch from pep517 to build, we should run with isolated=True (as described in this issue body):

    def setup_name_and_version(self):
        try:
            metadata = build.util.project_wheel_metadata(
                str(self.rootpath), isolated=False)    # <--- change to isolated=True, at least as a default

[fschulze]

Thanks for the detailed explanation. I think isolated=not self.args.no_isolation is the correct fix then, as it would do isolated builds by default, but with the --no-isolation option it would build both the releases and the docs with no isolation, so no surprises for either case.

[eachimei]

Thanks! I haven't got to give it a try yet, but it makes sense and sounds good!

[eachimei]

Tested isolated=not self.args.no_isolation and it looks good, works as expected.

[eachimei]

PR with the fix: #1009

[eachimei]

Thanks @fschulze ! 😃