Comments (4)
it is significantly faster while retaining the size info.
What timing are you talking about, could you give an example for your case?
Like if the some cleanup-script runs even for an hour each night - it should be fine, imo.
from artifactory-cleanup.
I think right now it's not possible to pass other rules attributes to DeleteDockerImagesOlderThan
- this is the reason why we requested it this way.
from artifactory-cleanup.
I stopped it after 3 hours.
I have a large backlog of things to cleanup, repo wide searches are very slow. Right now i'm using the following patch to filter to the common path of the artifacts returned, this avoid any additional parameters.
common_path = path.commonpath([artifact['path'] for artifact in artifacts])
args = ["items.find", {"$and": [{"repo": {"$eq": repo for repo in docker_repos}}, {"$or": [{"path": { "$match": f"{common_path}/*", }}]}]}]
Deletes are also slow in my case, each delete takes a couple minutes. Right now its performed serially, have parallel deletes been considered?
from artifactory-cleanup.
I stopped it after 3 hours.
It sounds awful, agreed. With common path it's possible that the common path will be /
- so the request will be the same...
But we can add it as a quick fix if it helps for some cases. Could you create a PR for that?
have parallel deletes been considered?
There ware no needs, but it's possible. We could use thread pool for that as an easy fix.
If you want to add it too - please create a separate PR for that, don't mix with the common path
from artifactory-cleanup.
Related Issues (20)
- Add option KeepLatestNImages HOT 2
- Problems with trashcan and conan HOT 3
- Possibility to use Regex HOT 5
- Exclude repo while deleting artifacts older than n days HOT 2
- how to delete empty folder with specific name HOT 2
- on prime - auth issue " 401 Client Error " HOT 3
- ExcludeDockerImages masks end up in missing layers HOT 2
- How to failover when Artifact is not found HOT 9
- Add support for using environment variables to pass parameters
- Question: Can someone advice best way how to manage Conan packages with revisions with Artifactory-cleanup? HOT 1
- Formatting Question - Possible Bug HOT 1
- docker-usage not possible HOT 2
- Create an LRU cleanup policy (redis-like)
- check method is a conflict in IncludeDockerImages rule HOT 1
- Duplicate manifest in aql HOT 2
- Bug: KeepLatestNVersionImagesByProperty - ValueError: Can not find version in [..] for multi-arch builds (buildx) HOT 1
- manifest_to_docker_images fails as path is not splittable
- Support for multi arch buildx images HOT 2
- Support for Archiving to Artifactory Cold Storage
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from artifactory-cleanup.