Coder Social home page Coder Social logo

Comments (10)

Steravy avatar Steravy commented on June 10, 2024 1

I saw that many developers have faced this problem, but despite of tons of github issues none of them presented the solution...
@Balastrong you didn`t found any solutions for it yet?

from github-stats.

Steravy avatar Steravy commented on June 10, 2024 1

I have found a lot of related issues, the same problem i would say. But none of them referring to permanent solutions. If you don`t want to be replacing the url every time the app is deployed i would suggest you to take a look at Clerk
If you found it interesting and applicable to this project, i would like to contribute with the implementation.

from github-stats.

Steravy avatar Steravy commented on June 10, 2024

Hi?
Can i have more details about this one? I would like to fix this one.

from github-stats.

Balastrong avatar Balastrong commented on June 10, 2024

Hey @Steravy, thanks for the help!

There's already some information in the description of the issue, the GitHub App wants an exact match on the callback but when deploying preview builds on Vercel it has a different URL every time.

It's not a "code" issue but rather something that has to be set somewhere, the questions are... what and where :D
Like, a wildcard on the app settings? I haven't found if this is actually possible, or passing nextauth a URL that matches one set in the app settings?

I'm open to suggestions :)

from github-stats.

ochowei avatar ochowei commented on June 10, 2024

hi @Balastrong,
I found this doc

<project-name>-<scope-slug>.vercel.app;
<project-name>-<author-name>-<scope-slug>.vercel.app;
my-project-git-this-is-really-an-extremely-long-bra-abc123xyz-scope-slug.vercel.app;

I am not sure is this what you want, please feel free to discuss.

from github-stats.

Balastrong avatar Balastrong commented on June 10, 2024

Thank you @ochowei!

Yes, that one is how the url is formed but on the GitHub App settings I can only put the exact link where the auth request comes from.
This means that if there is a different link for each branch/author, this can't work unfortunately :(

from github-stats.

Steravy avatar Steravy commented on June 10, 2024

@Balastrong If any other solutions wasn't yet implemented i believe i do have an idea to overcome this issue.

from github-stats.

Balastrong avatar Balastrong commented on June 10, 2024

@Steravy no, I haven't found a solution yet. Suggestions are more than welcome! :)

from github-stats.

Balastrong avatar Balastrong commented on June 10, 2024

Thank you @Steravy! The plan for now was to use a github app but I'll keep in mind that Cleck might be a valid option :)

from github-stats.

Kvnbbg avatar Kvnbbg commented on June 10, 2024

I'm not a fan of theory parody, but I've been brainstorming a solution to the problem of callback URLs for Vercel deployment previews. I think that DNS wildcards could be a good solution.

A DNS wildcard record matches any subdomain of a given domain. For example, a DNS wildcard record for *.eeee.com would match preview.eeee.com, api.eeee.com, and any other subdomain of example.eeee.com.

To use a DNS wildcard record to solve the callback URL problem, you would create a record for *.eeee.com that points to your Vercel deployment preview. You could then update your callback URL in GitHub to point to *.eeee.com. This would ensure that users are redirected to your Vercel deployment preview after they sign in to your GitHub App, regardless of which subdomain they are using.

from github-stats.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.