Coder Social home page Coder Social logo

Color Validation about wasp HOT 4 CLOSED

devinmatte avatar devinmatte commented on June 14, 2024
Color Validation

from wasp.

Comments (4)

tuantr10 avatar tuantr10 commented on June 14, 2024

Hi @devinmatte , may I work on this? I have never contributed to any other repositories rather than my own.
For the flow: I will limit the input value to 6-digits-length hex values.
I have 2 questions:

  • Should we also allow hex values with the length of 3?
  • Will empty input work with these 2 fields (theme_color, background_color)?

from wasp.

devinmatte avatar devinmatte commented on June 14, 2024

@tuantr10 Absolutely! I would love for someone to contribute.
Limiting to 6 values is perfect. If you want to allow 3 digit hexes that's fine, but I don't feel it required.
As for allowing empty input, look at the other methods that accept empty input, and set a default. I think #FFF should be the default value.

from wasp.

tuantr10 avatar tuantr10 commented on June 14, 2024

Thanks @devinmatte. I will create a PR when I finish.

from wasp.

tuantr10 avatar tuantr10 commented on June 14, 2024

@devinmatte please check and feedback my above pull request.
Cheers!

from wasp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.