CRSF device names longer than 12 characters break the device page about deviation

[hexfet]

What transmitter are you using?
What radio module are you using?
Can you please give an example of a device name that causes the failure?

I only have a Crossfire radio and it doesn't seem to have this problem. The device name is "XF Transmitter" which is 14 characters and works correctly.

You can try reducing the constant CRSF_MAX_NAME_LEN to see if the behavior changes.

[howels]

What transmitter are you using? What radio module are you using? Can you please give an example of a device name that causes the failure?

Jumper T8SGv2
ExpressLRS TX (various)
"BetaFPV Micro TX" or "HappyModel ES24TX"

I only have a Crossfire radio and it doesn't seem to have this problem. The device name is "XF Transmitter" which is 14 characters and works correctly.

You can try reducing the constant CRSF_MAX_NAME_LEN to see if the behavior changes.

This happens with ExpressLRS devices. We can for instance see the RX which has a shorter name but the TX is not visible with the default name "BetaFPV Micro TX"
I experimented a lot trying to shorten the length of strings but nothing seemed to work, Deviation would show a blank line when the input string was too long - it would be strongly desirable to truncate the string instead of showing a blank line.

Issue is reported by numerous other users trying out ExpressLRS, and is only resolved when they manually edit the ExpressLRS code to decrease the length of the device name. These device names are working fine under OpenTX and the CRSF protocol supports them but in DeviationTX they are shown as blank lines in the CRSF device page.

Regarding 14 character names - you may be right but the limit is either 12 or 14 characters and anything past that is rendered blank.

[howels]

FYI I have tried a custom build with CRSF_MAX_NAME_LEN increased to 40 characters and the 14 character limit still applies.

[hexfet]

Thanks for the pointer in the right direction. Should be fixed by #1020. Please give it a try.

[howels]

Thanks for the pointer in the right direction. Should be fixed by #1020. Please give it a try.

Thanks, I'll give it a go tomorrow. Really appreciate you looking at this!

[howels]

BTW this is now fixed as of 458a87e