Coder Social home page Coder Social logo

Card number duplicated about opensource HOT 8 CLOSED

developersdo avatar developersdo commented on September 25, 2024
Card number duplicated

from opensource.

Comments (8)

mecm1993 avatar mecm1993 commented on September 25, 2024 2

The cause of the weird behavior of issue #34 is because of the same amount of stargazers between repos. However, in my opinion this is a list of the most popular, trending or newest repos from our community.

Therefore, duplication of position should not be allowed, if there are two or more repos with the same amount of stargazers, then the amount of watchers or forks should come up to make the difference between positions.

from opensource.

hectoraristy avatar hectoraristy commented on September 25, 2024 1

It's nice to have it in the same position but in that way we don't have a validation to create an unique position number. So my suggestion is to remove the card number and give priority to the search bar.

from opensource.

rmariuzzo avatar rmariuzzo commented on September 25, 2024 1

@hekotoru the search in both the repos and devs is a must have. We have to creat an issue for that.

@mecm1993 I understand your point on the #34. Even if we use more fields we should deal properly with repos that can have the same popularity.

Personally, I think the same position number due to the same amount of stargazers can be confusing. With that I mind it would be better to use more fields as suggested by @mecm1993 and finally sitting by their repo name and done. What do you all think?

from opensource.

rmariuzzo avatar rmariuzzo commented on September 25, 2024

from opensource.

iCueto avatar iCueto commented on September 25, 2024

He means that the position numbers is duplicate... :)

from opensource.

hectoraristy avatar hectoraristy commented on September 25, 2024

I think the problem is here:

https://github.com/developersdo/opensource/blob/master/src/client/components/repositories/popular/Popular.js#L32-L39

from opensource.

rmariuzzo avatar rmariuzzo commented on September 25, 2024

It was intentional. Popular repositories are sorted by stargazers. However, two or more repositories can have same amount of stargazers. That's the reason I'm giving the same position.

What do you all think?

from opensource.

rmariuzzo avatar rmariuzzo commented on September 25, 2024

This will be handled at #40. I will close this.

from opensource.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.