Desse impl for char is unsound about desse

[devashishdxt]

Introducing a new trait function only for this usecase does not make much sense to me. There are two main options that I can think of:

• Return Result from deserialize_from().
• Panic in scenarios where input is invalid.

What do you think?

[MikailBag]

I would vote for Result, because it provides user with more control of error handling (return, panic, log, or maybe unchecked unwrap). Also, in client-server scenario bytes can come from untrusted source, and server should return error to client rather than panic.

[devashishdxt]

Yes. Result makes more sense here.

[devashishdxt]

Closing this in favour of #13

[Shnatsel]

Since this triggers UB from safe code, could you file a security advisory at https://github.com/RustSec/advisory-db? This will let users of your crate check if they're depending on a vulnerable version and upgrade.