AllowTCPForwarding set to `no` although I have `ssh_allow_tcp_forwarding: yes` about ansible-ssh-hardening

[rndmh3ro]

Sounds great, go ahead!

[rndmh3ro]

I'm suspecting this happened because Ansible took the no and turned it into a boolean, whereas when looking at the code (in particular following this commit), it checks if the value is in list ['yes', 'no', 'all', 'local'], thus checks for a string, not boolean.
Consequently, it seems that it is necessary to set 'yes' / 'no' as a string (with quotes) as such:

That's correct.

I haven't yet tested this assumption but it seems correct. In this case, it may be necessary to explicitly explain in the documentation, next to ssh_allow_tcp_forwarding, that the values yes, no, all or local have be fed as Python string, ie with quotes.

Sounds like a good idea, the readme was obviously not explicit enough. Do you want to create a PR for this?

[jeanmonet]

Sure, this would be a suggested wording. If it's fine for you I'll create a PR:

'no' to disable TCP Forwarding. Set to 'yes' to allow TCP Forwarding. If you are using OpenSSH >= 6.2 version, you can specify 'yes', 'no', 'all' or 'local'.

Note: values passed to this variable must be strings, thus values 'yes' and 'no' should be passed with quotes.

Update: PR #288

[rndmh3ro]

Fixed by #288