Comments are not terminated by newline about tree-sitter-sql

[dmfay]

Tree-sitter regexes are single-line by default so I think the explicit newline is actually throwing it off. Other grammars like JS, Python or Bash use .* sans newline for single-line comments; the Java grammar has what seems like an unnecessary negative (anything but a newline) character class.

I've created #74 , please check it out!

[DerekStride]

Could a lazy /.*?\n/ do the trick?

Yeah I think that would do it, want to open a PR for it?

[LeoniePhiline]

I tried locally and couldn't make it work. Am I doing something wrong?

Here's what I do, using helix:

• In $HELIX_RUNTIME/grammars run rm sql.so
• In $HELIX_RUNTIME/grammars/sources/sql edit grammar.js
• Run hx --grammar build
• Open a fresh hx instance to check if it changed something.

It confirms rebuilding sql - but my changes to grammar.js appear to have no effect at all. (Even if I change "--" for something bogus, comments in the SQL file are still highlighted as comments.)

Could you try verifying the fix?

[matthias-Q]

I have tested it on my machine and the suggested regex does not fix the issue:

comment: _ => seq('--', /.*?\n/),

with following SQL:

--
CREATE TABLE tx_digibordauthentication_activity_log
(
  uid int(11) unsigned NOT NULL auto_increment,
);

produces this AST:

(program [0, 0] - [5, 0]
  (comment [0, 0] - [2, 0])
  (ERROR [2, 0] - [4, 2]
    (keyword_not [3, 23] - [3, 26])
    (keyword_null [3, 27] - [3, 31])
    (keyword_auto_increment [3, 32] - [3, 46])))
playground.sql	0 ms	(ERROR [2, 0] - [4, 2])

[LeoniePhiline]

Fixed by #74