Comments (8)
I think this would be preferred. We already have some organization issues with rector upgrades for cake 5 since we don't maintain the package.
The upgrade
package was used to perform other non-rector upgrades in the past. Now, its just a rector wrapper, and it might be time to simply rely on a rector package.
from rector-cakephp.
@markstory @othercorey here the PR cakephp/upgrade#197 :)
from rector-cakephp.
/cc @markstory @othercorey FYI
from rector-cakephp.
Makes sense to me as well. In the past rector has has handled doing upgrades to these rulesets when there were breaking changes. With this project and other packages moving to other communities will there be fewer breaking changes in rector?
from rector-cakephp.
Exactly. The less external complexity per unique framework, the more stability 👍
from rector-cakephp.
@markstory rector-cakephp no longer exists in scoped rector:dev-main, see
https://github.com/rectorphp/rector/tree/32c7260742dc9f3f39c1633afeedcea34d7bdfa7/vendor/rector
Please try latest rector/rector:dev-main and copy rules from here, for note, the config needs to make autowire working can be followed by:
You can modify to target the cakephp-upgrade path directory that the rules and services copied.
from rector-cakephp.
@TomasVotruba Can you clarify the transition path for us? What specifically do you need us to deliver?
from rector-cakephp.
@othercorey cakephp/upgrade
is using CakePHPSetList
from this package, which previously included in scoped vendor/
of rector/rector:<=0.14.5:
https://github.com/rectorphp/rector/tree/0.14.5/vendor/rector/rector-cakephp
As current rector/rector:dev-main no longer deliver rector/rector-cakephp
package under vendor/
https://github.com/rectorphp/rector/tree/a0186945857fec715079795f4f955b9dfa9f89cf/vendor/rector
consuming cakephp/upgrade
will cause error in next release, eg: rector/rector: 0.14.6,
I think you can try:
- update rector dependency to
rector/rector:dev-main
atcakephp/upgrade
- move the rules from here to there
Then, on next release, you can update rector dependency to whatever next release number is, eg: rector/rector: ^0.14.6
from rector-cakephp.
Related Issues (3)
- How to replace chained method call HOT 2
- Could not process file HOT 13
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rector-cakephp.