Coder Social home page Coder Social logo

Comments (8)

othercorey avatar othercorey commented on June 9, 2024 4

I think this would be preferred. We already have some organization issues with rector upgrades for cake 5 since we don't maintain the package.

The upgrade package was used to perform other non-rector upgrades in the past. Now, its just a rector wrapper, and it might be time to simply rely on a rector package.

from rector-cakephp.

samsonasik avatar samsonasik commented on June 9, 2024 1

@markstory @othercorey here the PR cakephp/upgrade#197 :)

from rector-cakephp.

samsonasik avatar samsonasik commented on June 9, 2024

/cc @markstory @othercorey FYI

from rector-cakephp.

markstory avatar markstory commented on June 9, 2024

Makes sense to me as well. In the past rector has has handled doing upgrades to these rulesets when there were breaking changes. With this project and other packages moving to other communities will there be fewer breaking changes in rector?

from rector-cakephp.

TomasVotruba avatar TomasVotruba commented on June 9, 2024

Exactly. The less external complexity per unique framework, the more stability 👍

from rector-cakephp.

samsonasik avatar samsonasik commented on June 9, 2024

@markstory rector-cakephp no longer exists in scoped rector:dev-main, see

https://github.com/rectorphp/rector/tree/32c7260742dc9f3f39c1633afeedcea34d7bdfa7/vendor/rector

Please try latest rector/rector:dev-main and copy rules from here, for note, the config needs to make autowire working can be followed by:

https://github.com/rectorphp/rector-cakephp/blob/a489bf049d6672d9ecdc03280f3f0f29c810cdd4/config/config.php#L10-L16

You can modify to target the cakephp-upgrade path directory that the rules and services copied.

from rector-cakephp.

othercorey avatar othercorey commented on June 9, 2024

@TomasVotruba Can you clarify the transition path for us? What specifically do you need us to deliver?

from rector-cakephp.

samsonasik avatar samsonasik commented on June 9, 2024

@othercorey cakephp/upgrade is using CakePHPSetList from this package, which previously included in scoped vendor/ of rector/rector:<=0.14.5:

https://github.com/rectorphp/rector/tree/0.14.5/vendor/rector/rector-cakephp

As current rector/rector:dev-main no longer deliver rector/rector-cakephp package under vendor/

https://github.com/rectorphp/rector/tree/a0186945857fec715079795f4f955b9dfa9f89cf/vendor/rector

consuming cakephp/upgrade will cause error in next release, eg: rector/rector: 0.14.6,

I think you can try:

  1. update rector dependency to rector/rector:dev-main at cakephp/upgrade
  2. move the rules from here to there

Then, on next release, you can update rector dependency to whatever next release number is, eg: rector/rector: ^0.14.6

from rector-cakephp.

Related Issues (3)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.