Comments (5)
@skydivedan No worries, take your time, it can wait till Monday =)
As for tableView.shouldIndentWhileEditingRowAt
- it's different because UITableViewCell does not actually call delegate method if you ask it's property shouldIndentWhileEditing
, and 4 steps logic I described earlier should work fine.
from dttableviewmanager.
Hey!
I believe this might be a bug in DTCollectionViewManager. From documentation on UICollectionViewDelegate collectionView(_:canFocusItemAt:)
:
You can use this method, or a cell’s canBecomeFocused method, to control which items in the collection view can receive focus. The focus engine calls the cell’s canBecomeFocused method first, the default implementation of which defers to the collection view and this delegate method.
Which is unfortunate, because this event implementation in DTCollectionViewManager is implemented like so:
https://github.com/DenHeadless/DTCollectionViewManager/blob/master/Source/DTCollectionViewDelegate.swift#L181
And so what I was trying to do is
- Call closure event, if it's registered
- Call real UICollectionViewDelegate method, if it's implemented
- Call cell's canBecomeFocused.
- Return true if all other steps fail as a sensible default.
What seems to be happening is step 3 implicitly calls step 2 in UICollectionView implementation which leads to infinite recursion.
I don't have experience of working with this API, but it seems like removing step 3 in DTCollectionViewDelegate implementation looks like the way to go. What do you think?
from dttableviewmanager.
Yes, your assessment looks correct. Additionally, you'll have to take out the same clause in DTTableViewDelegate.canFocusRowAt
. I'm going to run some tests here, and see what develops.
from dttableviewmanager.
Quick note... sorry to say but I can't get back to this until Monday, unfortunately. But I dug around a bit more in the code and found a similar example of this DTTableViewDelegate
in tableView.shouldIndentWhileEditingRowAt
.
from dttableviewmanager.
This bug is fixed in DTCollectionViewManager 6.4.1 release. Closing.
from dttableviewmanager.
Related Issues (20)
- How update cell, without hidden keyboard? HOT 1
- any advice on putting UICollectionViews into UITableViewCells? HOT 1
- CollapsibleTable
- Cocoapods error HOT 2
- Version 6.1.0-beta.1 is not compiled from original source files HOT 1
- Wrong tableView section header width. HOT 2
- TableView doesn't update without animation after reloadData() HOT 1
- I'm a dummy, but how to set section header? HOT 5
- crash when replacing items using `RealmStorage.setSection`, if amt items in new list don't match... HOT 4
- How to make a cell reuse only for specific indexpath HOT 1
- Add items without animation HOT 2
- Mapping view model for sections with NSFetchedResultsController HOT 1
- Side effect with using coreDataUpdater() HOT 1
- heightForHeaderInSection call HOT 7
- TableViewUpdater for local search HOT 1
- Issue with programmatically added tableView HOT 2
- Setting/Updating section header for specific section HOT 1
- Update Model in UITableViewCell class HOT 7
- Cannot build for simulator on M1 Mac HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dttableviewmanager.