Comments (12)
@ry This would help Homebrew to continue supporting High Sierra for deno
, because the binary bottles are build on the macOS version they should run on and currently it's not possible to build it on High Sierra because of a too old libtool
.
from rusty_v8.
do you use rust 1.4.2 ? if not, try to update rust !
from rusty_v8.
This is with rust 1.42.0. Also a syntax error in BUILD.gn
files during the gn gen
run should be completely unrelated to rust though.
from rusty_v8.
do you use rust 1.4.2 ? if not, try to update rust !
I assume that is Rust 1.42.0.
Anyway, it seems working fine now (with Rust 1.42.0).
from rusty_v8.
@chenrui333 but only because you're using the precompiled rust_v8
binary. Building it from source by setting V8_FROM_SOURCE=1
still fails.
from rusty_v8.
@chrmoritz what version of gn are you using? We updated the binary during the upgrade.
CI is built from source still.
from rusty_v8.
@ry: The error from above is from cloning this repository and using it's default precompiled binaries (aka out/gn_ninja_binaries/mac/gn
).
But I keep that in mind, that we might have to update gn
too in the homebrew formula.
from rusty_v8.
@ry: Thx, updating gn
fixes the issue.
I did the test from above in an old checkout with the old binaries still laying around and it didn't update them. Also we need to update gn
in homebrew.
from rusty_v8.
@ry FYI: The last remaining issue with the v8 upgrade in Homebrew is, that denoland/chromium_build@8a57822 breaks support for macOS High Sierra (10.13), because libtool -D
isn't available there.
from rusty_v8.
I wonder if setting “enable_dsyms = false” will help?
I think this might be caused by c9b8208
from rusty_v8.
It comes from the V8 upgrade to 8.2 and more specific this commit: denoland/chromium_build@8a57822. Google has just decided to drop support for building V8 on High Sierra (it will still run on it however). The libtool
shipped with HighSierra (CLT or the max possible XCode 10.1) isn't new enough and doesn't support the -D
flag. Only the ZERO_AR_DATE
env var, from which they've moved in said commit, is supported on macOS 10.13.
I don't think we can do anything about it except dropping support for building on High Sierra too (or reverting said commit of course).
from rusty_v8.
@chrmoritz I’d be happy to revert that commit in our local fork if it helps.
from rusty_v8.
Related Issues (20)
- ICU Error in DateTimePatternGeneratorCache::CreateGenerator HOT 1
- [Feature request] Support for Linux PowerPC64 Little Endian
- V8 Sandbox feature HOT 8
- ASAN failure: context_from_object_template HOT 2
- API to create and re-use StartupData HOT 4
- [Bug Report]: Static assertion failed while compiling to target_arch = arm
- [question] How do scopes work? HOT 3
- Unsoundness when starting an isolate per thread HOT 6
- ci: x86_64 build failed on macos-latest image HOT 2
- `v8::String::new_from_onebyte_const` crash on Android aarch64 HOT 6
- Failed to build V8 on riscv64
- Use of deprecated APIs in binding.cc
- `clear_kept_objects` is flaky when run in parallel HOT 1
- Property setter and definer should not return "non-hole" values HOT 2
- Catch Reached heap limit crashes? HOT 1
- feature: wasm32 target HOT 1
- `ExternalOneByteStringResource::as_str` is unsound
- Question: Global context and callbacks HOT 3
- rust_v8 0.98.0,0.99.0 build failure HOT 13
- Build on windows will fail unless run cargo build with admin acess or developer mode HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rusty_v8.