gn gen failure on macOS about rusty_v8

[chrmoritz]

@ry This would help Homebrew to continue supporting High Sierra for deno, because the binary bottles are build on the macOS version they should run on and currently it's not possible to build it on High Sierra because of a too old libtool.

[IllusionPerdu]

do you use rust 1.4.2 ? if not, try to update rust !

[chrmoritz]

This is with rust 1.42.0. Also a syntax error in BUILD.gn files during the gn gen run should be completely unrelated to rust though.

[chenrui333]

do you use rust 1.4.2 ? if not, try to update rust !

I assume that is Rust 1.42.0.

Anyway, it seems working fine now (with Rust 1.42.0).

[chrmoritz]

@chenrui333 but only because you're using the precompiled rust_v8 binary. Building it from source by setting V8_FROM_SOURCE=1 still fails.

[ry]

@chrmoritz what version of gn are you using? We updated the binary during the upgrade.

CI is built from source still.

[chrmoritz]

@ry: The error from above is from cloning this repository and using it's default precompiled binaries (aka out/gn_ninja_binaries/mac/gn).

But I keep that in mind, that we might have to update gn too in the homebrew formula.

[chrmoritz]

@ry: Thx, updating gn fixes the issue.

I did the test from above in an old checkout with the old binaries still laying around and it didn't update them. Also we need to update gn in homebrew.

[chrmoritz]

@ry FYI: The last remaining issue with the v8 upgrade in Homebrew is, that denoland/chromium_build@8a57822 breaks support for macOS High Sierra (10.13), because libtool -D isn't available there.

[ry]

I wonder if setting “enable_dsyms = false” will help?

I think this might be caused by c9b8208

[chrmoritz]

It comes from the V8 upgrade to 8.2 and more specific this commit: denoland/chromium_build@8a57822. Google has just decided to drop support for building V8 on High Sierra (it will still run on it however). The libtool shipped with HighSierra (CLT or the max possible XCode 10.1) isn't new enough and doesn't support the -D flag. Only the ZERO_AR_DATE env var, from which they've moved in said commit, is supported on macOS 10.13.

I don't think we can do anything about it except dropping support for building on High Sierra too (or reverting said commit of course).

[ry]

@chrmoritz I’d be happy to revert that commit in our local fork if it helps.