Coder Social home page Coder Social logo

Comments (5)

kt3k avatar kt3k commented on June 11, 2024

Note: In Node.js, +0 and -0 are not equal with assert.strictEqual assertion. I'm not sure the suggested behavior is expected

from deno_std.

iuioiua avatar iuioiua commented on June 11, 2024

That's a fair point. Should we adhere to ECMA's definition of strict equality (===) or mimic Node's implementation, which uses Object.is()?

from deno_std.

kt3k avatar kt3k commented on June 11, 2024

Jest and Vitest also follow what Node.js does. The below examples throw in jest and vitest:

Jest

expect(+0).toStrictEqual(-0);

Vitest

import { expect, test } from 'vitest'
expect(+0).toStrictEqual(-0);

from deno_std.

iuioiua avatar iuioiua commented on June 11, 2024

Ok. I'll revert and instead add a note explaining the behavior.

from deno_std.

iuioiua avatar iuioiua commented on June 11, 2024

fix(assert): handle assertStrictEquals(-0, +0) correctly #4715

See #4718

from deno_std.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.