Comments (5)
Note: In Node.js, +0 and -0 are not equal with assert.strictEqual
assertion. I'm not sure the suggested behavior is expected
from deno_std.
That's a fair point. Should we adhere to ECMA's definition of strict equality (===
) or mimic Node's implementation, which uses Object.is()
?
from deno_std.
Jest and Vitest also follow what Node.js does. The below examples throw in jest and vitest:
Jest
expect(+0).toStrictEqual(-0);
Vitest
import { expect, test } from 'vitest'
expect(+0).toStrictEqual(-0);
from deno_std.
Ok. I'll revert and instead add a note explaining the behavior.
from deno_std.
fix(assert): handle
assertStrictEquals(-0, +0)
correctly #4715
See #4718
from deno_std.
Related Issues (20)
- issue: `decodeBase32()` throws on bad padding length HOT 2
- stop doing deprecation process for 0.x version packages
- suggestion: stabilize `KeyStack` HOT 3
- suggestion: remove `GlobToRegExpOptions.os` HOT 2
- suggestion: add signed cookie example
- suggestion: make `isWindows` cross-runtime in `@std/path`
- suggestion: add base32hex to encoding HOT 1
- stabilize `@std/html`
- stabilize `@std/path`
- stabilize `@std/toml` HOT 1
- stabilize `@std/url` HOT 1
- Snapshot testing generation is non-deterministic/broken since 1.37.0 HOT 3
- to-do: re-write breaking PRs
- Leaks detected with ` await new FakeTime().runMicrotasks();` HOT 2
- Automate tagging of the release commit
- suggestion: improve `@std/assert` docs HOT 2
- assertNotEquals assertion error message discrepancy HOT 2
- suggestion: have `url.dirname()` return `string` instead of `URL` HOT 7
- proposal: stabilize `data-structures`
- RC feedback: rename `parse`/`stringify` to `parseToml`/`stringifyToml` HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from deno_std.