Coder Social home page Coder Social logo

Comments (5)

dsherret avatar dsherret commented on May 5, 2024 2

@kitsonk in ts-morph I'm planning to use it and it would only get called if someone analyzes deno code (ex. for node code it wouldn't be necessary).

from deno_graph.

kitsonk avatar kitsonk commented on May 5, 2024 1

Thanks that makes sense. Also, TLA can actually be a challenge with things like Deploy when trying to instantiate the isolate. Having a constructor does make sense.

The pattern here works well (which was adapted from other projects as well):

https://github.com/lucacasonato/comrak-wasm/blob/a8b06e882c43c06de1d1a48e894b6c4f1c0de921/mod.ts#L10-L18

I also do like the init() versus load()...

from deno_graph.

kitsonk avatar kitsonk commented on May 5, 2024

I agree with the first point, but:

deno graph is imported but not used

😕 why would someone do that. What valid scenarios are there for that?

from deno_graph.

dsherret avatar dsherret commented on May 5, 2024

The one thing I like about load vs init is that load forces you to call it in order to use the API, whereas init doesn't and I'm not sure how friendly the error message is if you forget to (or at least we'd have to implement something). I can implement init though.

from deno_graph.

dsherret avatar dsherret commented on May 5, 2024

This is done now in #158.

from deno_graph.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.