Allow Passing an Arg for Deno Version about deno_docker

[hayd]

Ah, I see! How does this work with dockerhub publishing? Or do you do this instead (and just copy the dockerfile always)?
Do node etc. do this same ARG thing?

[ebebbington]

I'm not entirely sure to be honest, i'm unfamiliar with building docker images for docker hub. Actually.. i guess they tag their versions, which is the ARG eg FROM node:14.1.7

Maybe instead of an ARG, you could have tagged images? Not entirely sure how this would work though, and i'm guessing it might require manual work, whereas using ARG, you probably wouldn't have to make any changes whatsoever when a new Deno version is released

[hayd]

@ebebbington I think tagged images is what we do at the moment. I wonder if there is a way to have the best of both: tagged images that allow you to pass the ARG version to override should you so wish.

The benefit of dockerhub is it caches - though this is somewhat less of an issue for images that are not building (only downloading)...

[hayd]

@ebebbington In user code, you can do something like:

ARG  DENO_VERSION=latest
FROM hayd/debian-deno:${DENO_VERSION}

...

https://docs.docker.com/engine/reference/builder/#understand-how-arg-and-from-interact

[ebebbington]

Tbh i think it would be good enough for users to do:

FROM hayd/debian-deno:v1.5.3

I guess I was wrong to suggest an ARG if images are already tagged

So are you saying the above is already supported?

[ebebbington]

Yeeh i can see they are by looking at the readme, not sure how long that's been there xD Well if images are tagged i don't think there's a need for an ARG? If you agree then feel free to close this issue, i'm happy for it to as the 'question' has been resolved

[hayd]

Going to close but still unsure if this is for the best