Coder Social home page Coder Social logo

[Question] Simplify? about deno_docker HOT 6 CLOSED

denoland avatar denoland commented on April 28, 2024
[Question] Simplify?

from deno_docker.

Comments (6)

ebebbington avatar ebebbington commented on April 28, 2024 1

Also FYI turns out the debian-stable-slim image is 69MB on my machine, so really 0 difference at all

from deno_docker.

ebebbington avatar ebebbington commented on April 28, 2024

@hayd i'm not too familiar to installing it through GH, but though through deno.land is official right? I assume you have to change the permissions on the file due to installing it through GH? Which is something not needed when installing through deno.land

from deno_docker.

hayd avatar hayd commented on April 28, 2024

I just mean, that deno.land uses GH behind the scenes. It's a good point that it is official. 🤔

from deno_docker.

ebebbington avatar ebebbington commented on April 28, 2024

Of course it's entirely up to you

If you are against any ideas then feel free to close this issue 👍 I'll leave it open if you wanted to discuss it more or it might be a good idea for the future or something

from deno_docker.

hayd avatar hayd commented on April 28, 2024

I think the reason to keep the current way is it is explicit (in a single RUN step):

  • install curl and unzip
  • curl the file from GH
  • unzip
  • uninstall curl and unzip

deno install essentially does the same thing (the curl and unzip), but it's obscured.

I'm not really convinced that using deno install is any simpler! 🤷


BTW In your example above you do the curl/unzip install in a previous step, this bloats the image a little (though those are both small), I think what the docker file should do is install deno only (and set ENV variables) no other libs that aren't required for deno to run.


That said, very happy to add slim (I thought the current debian image was slim, but it is tied to a specific tag).

Can you open another issue for the ARGS concern? I am not sure I grok the issue but it sounds important/useful to fix. (and seems independent of using deno install in the dockerfile)

from deno_docker.

ebebbington avatar ebebbington commented on April 28, 2024

I'm not really convinced that using deno install is any simpler! 🤷

Fair enough :)


To be honest, i'm not sure the size of debian-slim compared to the one you use (i only assume it's smaller), but there might not even be much difference in size


FYI Made the issue for the args: #88

from deno_docker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.