import map inconsistency between lsp and runtime about deno

[nayeemrmn]

This should be fixed in 1.45.3. Please try it out and comment if it's not

[Reububble]

@nayeemrmn The issue persists in 1.45.3

[dsherret]

TLDR: This isn't a bug. The CLI only discovers the root deno.json file, but the LSP discovers all deno.json files.

The reason this occurs, is because in the lsp it treats the files under each deno.json as being owned by that config. If you were running from the root directory, essentially, the LSP creates an import map that looks like the following:

{
  "imports": {
    "a/": "./a/",
    "b/": "./b/",
    "s/": "./a/s/src/"
  },
  "scopes": {
    "./a/": {
      "s/": "./a/s/src/"
    },
    "./b/": {
      "s/": "./b/s/src/"
    }
  }
}

Which you can see leads to the same error message that you're encountering in the import map:

> deno check c.ts
Check file:///V:/scratch/c.ts
error: TS2345 [ERROR]: Argument of type '{ [s]: number; }' is not assignable to parameter of type 'S'.
  Property '[s]' is missing in type '{ [s]: number; }' but required in type 'S'.
xs(b); // LSP Error in Deno 1.45.0...
   ^
    at file:///V:/scratch/c.ts:10:4

    '[s]' is declared here.
      [s]: number;
      ~~~
        at file:///V:/scratch/a/s/src/s.ts:4:3

This is because the LSP discovers all deno.json files, but the deno CLI doesn't. When running c.ts, the CLI only discovers the root deno.json file and so it resolves everything with a s/ specifier to the "./a/s/src/" folder.

Another way you can reproduce this behaviour in the CLI, is to use workspaces, which allows you to tell the CLI about the other deno.json files, which will emulate the behaviour in the LSP. For example, adding a workspace field to the root deno.json will also yield the same type checking error on the CLI:

{
  "workspace": {
    "members": [
      "./a",
      "./b"
    ]
  },
  "imports": {
    "a/": "./a/",
    "b/": "./b/",
    "s/": "./a/s/src/"
  }
}

[nayeemrmn]

To summarise again, you have to add a workspace field to unify resolution across a project spanning multiple deno.json scopes, otherwise you may come across differences between CLI and LSP.