Comments (4)
This should be fixed in 1.45.3. Please try it out and comment if it's not
from deno.
@nayeemrmn The issue persists in 1.45.3
from deno.
TLDR: This isn't a bug. The CLI only discovers the root deno.json file, but the LSP discovers all deno.json files.
The reason this occurs, is because in the lsp it treats the files under each deno.json as being owned by that config. If you were running from the root directory, essentially, the LSP creates an import map that looks like the following:
{
"imports": {
"a/": "./a/",
"b/": "./b/",
"s/": "./a/s/src/"
},
"scopes": {
"./a/": {
"s/": "./a/s/src/"
},
"./b/": {
"s/": "./b/s/src/"
}
}
}
Which you can see leads to the same error message that you're encountering in the import map:
> deno check c.ts
Check file:///V:/scratch/c.ts
error: TS2345 [ERROR]: Argument of type '{ [s]: number; }' is not assignable to parameter of type 'S'.
Property '[s]' is missing in type '{ [s]: number; }' but required in type 'S'.
xs(b); // LSP Error in Deno 1.45.0...
^
at file:///V:/scratch/c.ts:10:4
'[s]' is declared here.
[s]: number;
~~~
at file:///V:/scratch/a/s/src/s.ts:4:3
This is because the LSP discovers all deno.json files, but the deno CLI doesn't. When running c.ts
, the CLI only discovers the root deno.json file and so it resolves everything with a s/
specifier to the "./a/s/src/"
folder.
Another way you can reproduce this behaviour in the CLI, is to use workspaces, which allows you to tell the CLI about the other deno.json files, which will emulate the behaviour in the LSP. For example, adding a workspace field to the root deno.json will also yield the same type checking error on the CLI:
{
"workspace": {
"members": [
"./a",
"./b"
]
},
"imports": {
"a/": "./a/",
"b/": "./b/",
"s/": "./a/s/src/"
}
}
from deno.
To summarise again, you have to add a workspace
field to unify resolution across a project spanning multiple deno.json
scopes, otherwise you may come across differences between CLI and LSP.
from deno.
Related Issues (20)
- Incorrect CPU usage stats on Linux
- Do not surface permission denied errors for .npmrc in home directory HOT 2
- Session Ids returned in Jupyter Kernel responses are incorrect HOT 1
- ReadableStreamDefaultControllerCallback/UnderlyingSourcePullCallback<string>.enqueue "not callable" type checking error in 1.45.3
- Bug: npm postinstall scripts should run with `deno run -A`
- Bug: dyld[3532]: missing symbol called in `sqlite3` HOT 2
- Add integration test for #24727
- JavaScript doesn't support decorators HOT 2
- specs::npm::lifecycle_scripts::node_gyp is flaky HOT 2
- High disk write volume on .cache sqlite databases. HOT 4
- Rename confusing --allow-none flag in `deno test` HOT 1
- `deno -h` missing help for `deno publish`
- `deno run` doesn't terminate when `node:child_process.fork()` is used HOT 2
- `upgrade::upgrade_invalid_lockfile` is flaky
- `specs::publish::invalid_import_esm_sh_suggestion` is flaky
- Missing LSP auto-completion for Node imports when package.json exists HOT 5
- Support for navigator.onLine
- Response.clone() is slower than returning a new Response
- Add options to separate Worker's DENO_DIR and import map
- node:readline/promises don't work
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from deno.